bug#70786: [PATCH] Quietly skip 'lua-ts-mode' tests

bug#70786: [PATCH] Quietly skip 'lua-ts-mode' tests

[john muhl]

Tags: patch

Change the test to be silent when they’re skipped due to the
grammar being unavailable.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.41, cairo version 1.18.0) of 2024-05-02 built on localhost
Repository revision: 962bb71b4a813eb9c3832494746695d32d6f9109
Repository branch: master
System Description: Fedora Linux 39 (Thirty Nine)

Configured using:
 'configure --with-pgtk --prefix=/home/jm/.local'

bug#70786: [PATCH] Quietly skip 'lua-ts-mode' tests

[john muhl]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-Quietly-skip-lua-ts-mode-tests-bug-70786.patch --]
[-- Type: text/x-patch, Size: 2209 bytes --]

From 96f1af589a7cef3fba3ff05a67af6659a58f9be1 Mon Sep 17 00:00:00 2001
From: john muhl <jm@pub.pink>
Date: Sat, 27 Apr 2024 18:52:41 -0500
Subject: [PATCH] Quietly skip 'lua-ts-mode' tests (bug#70786)

* test/lisp/align-tests.el (align-lua):
* test/lisp/progmodes/lua-ts-mode-tests.el
(lua-ts-test-indentation):
(lua-ts-test-movement):
(lua-ts-test-font-lock):
(lua-ts-test-which-function): Suppress warnings when the grammar is not
installed.
---
 test/lisp/align-tests.el                 | 2 +-
 test/lisp/progmodes/lua-ts-mode-tests.el | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/test/lisp/align-tests.el b/test/lisp/align-tests.el
index cd309ea07bf..eaebaf8360c 100644
--- a/test/lisp/align-tests.el
+++ b/test/lisp/align-tests.el
@@ -52,7 +52,7 @@ align-latex
 (autoload 'treesit-ready-p "treesit")
 
 (ert-deftest align-lua ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (let ((comment-column 20)
         (indent-tabs-mode nil))
     (ert-test-erts-file (ert-resource-file "lua-ts-mode.erts")
diff --git a/test/lisp/progmodes/lua-ts-mode-tests.el b/test/lisp/progmodes/lua-ts-mode-tests.el
index a7b637d18d1..68b8c9ccfaa 100644
--- a/test/lisp/progmodes/lua-ts-mode-tests.el
+++ b/test/lisp/progmodes/lua-ts-mode-tests.el
@@ -26,20 +26,20 @@
 (require 'which-func)
 
 (ert-deftest lua-ts-test-indentation ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (ert-test-erts-file (ert-resource-file "indent.erts")))
 
 (ert-deftest lua-ts-test-movement ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (ert-test-erts-file (ert-resource-file "movement.erts")))
 
 (ert-deftest lua-ts-test-font-lock ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (let ((treesit-font-lock-level 4))
     (ert-font-lock-test-file (ert-resource-file "font-lock.lua") 'lua-ts-mode)))
 
 (ert-deftest lua-ts-test-which-function ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (with-temp-buffer
     (insert-file-contents (ert-resource-file "which-function.lua"))
     (lua-ts-mode)
-- 
2.41.0

bug#70786: [PATCH] Quietly skip 'lua-ts-mode' tests

[john muhl]

[-- Attachment #1: Type: text/plain, Size: 21 bytes --]

Forgot a semicolon.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Quietly-skip-lua-ts-mode-tests-bug-70786.patch --]
[-- Type: text/x-patch, Size: 2207 bytes --]

From a05580d2046a133786995bc60cbd60948606ce6b Mon Sep 17 00:00:00 2001
From: john muhl <jm@pub.pink>
Date: Sat, 27 Apr 2024 18:52:41 -0500
Subject: [PATCH] ; Quietly skip 'lua-ts-mode' tests (bug#70786)

* test/lisp/align-tests.el (align-lua):
* test/lisp/progmodes/lua-ts-mode-tests.el
(lua-ts-test-indentation):
(lua-ts-test-movement):
(lua-ts-test-font-lock):
(lua-ts-test-which-function): Suppress warnings when the grammar is not
installed.
---
 test/lisp/align-tests.el                 | 2 +-
 test/lisp/progmodes/lua-ts-mode-tests.el | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/test/lisp/align-tests.el b/test/lisp/align-tests.el
index cd309ea07bf..eaebaf8360c 100644
--- a/test/lisp/align-tests.el
+++ b/test/lisp/align-tests.el
@@ -52,7 +52,7 @@ align-latex
 (autoload 'treesit-ready-p "treesit")
 
 (ert-deftest align-lua ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (let ((comment-column 20)
         (indent-tabs-mode nil))
     (ert-test-erts-file (ert-resource-file "lua-ts-mode.erts")
diff --git a/test/lisp/progmodes/lua-ts-mode-tests.el b/test/lisp/progmodes/lua-ts-mode-tests.el
index a7b637d18d1..68b8c9ccfaa 100644
--- a/test/lisp/progmodes/lua-ts-mode-tests.el
+++ b/test/lisp/progmodes/lua-ts-mode-tests.el
@@ -26,20 +26,20 @@
 (require 'which-func)
 
 (ert-deftest lua-ts-test-indentation ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (ert-test-erts-file (ert-resource-file "indent.erts")))
 
 (ert-deftest lua-ts-test-movement ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (ert-test-erts-file (ert-resource-file "movement.erts")))
 
 (ert-deftest lua-ts-test-font-lock ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (let ((treesit-font-lock-level 4))
     (ert-font-lock-test-file (ert-resource-file "font-lock.lua") 'lua-ts-mode)))
 
 (ert-deftest lua-ts-test-which-function ()
-  (skip-unless (treesit-ready-p 'lua))
+  (skip-unless (treesit-ready-p 'lua t))
   (with-temp-buffer
     (insert-file-contents (ert-resource-file "which-function.lua"))
     (lua-ts-mode)
-- 
2.41.0


[-- Attachment #3: Type: text/plain, Size: 112 bytes --]



john muhl <jm@pub.pink> writes:

> [1. text/x-patch; 0001-Quietly-skip-lua-ts-mode-tests-bug-70786.patch]...

bug#70786: [PATCH] Quietly skip 'lua-ts-mode' tests

[Yuan Fu]

> On May 5, 2024, at 6:46 AM, john muhl <jm@pub.pink> wrote:
> 
> Forgot a semicolon.

Merged, thanks!

Yuan