From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: with-editor seems like a bug fix Date: Sun, 30 Jun 2024 13:51:21 +0200 Message-ID: <87y16mejie.fsf@ledu-giraud.fr> References: <86frsz6i6v.fsf@gnu.org> <87o77miusp.fsf@ledu-giraud.fr> <8634oy65mo.fsf@gnu.org> <87msn4nh2p.fsf@gmx.de> <86wmm7j55c.fsf@gnu.org> <87ed8f531w.fsf@gmx.de> <86o77jj470.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24546"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Albinus , rms@gnu.org, emacs-devel@gnu.org, jonas@bernoul.li To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 30 13:52:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNt6T-00069g-JI for ged-emacs-devel@m.gmane-mx.org; Sun, 30 Jun 2024 13:52:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNt5k-0006LG-Tg; Sun, 30 Jun 2024 07:51:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNt5i-0006Kp-8o for emacs-devel@gnu.org; Sun, 30 Jun 2024 07:51:34 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNt5f-0000WJ-Kj; Sun, 30 Jun 2024 07:51:33 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=wbo2FkSz uq39MVLb2ObfWl1Gr4/13ffSgqlLyiTjdw8=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=q+2nFzzFgPp4Ae1dhoEQRnzOVCpidf 4fXHHSOH5j7zBnbTHjFJnwzZz6bXXLkKELy3yOL+lnM0YY97CCOzfEBQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=wbo2FkSzuq39MVLb 2ObfWl1Gr4/13ffSgqlLyiTjdw8=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=kN1yCdptAoi2BZ6a4FdI78bX9EWdDUmWO1NW9q gtszAUri58f+ws2r9tcCRa9WEpg6t7NvAK2ZTKVBRJP+nLx30hXjmD/uYz6cHcVUv3Lez2 KNeYB0ykbHZauDyR89FgEfD53jKJNhuxqAgLWkbsAfbuKC/YxiqUzopc6/uik1BqDfdZMv mastIrpvB8mgsc+xzr67fJtWO8mjyAq4AZJ4q0GFcpO9qqnCln9aTpEIoGAghaouaxdcWZ XnGoqSwbif8xE/TcG0jxef3GwXO/9NeHJM64Me3OZwKgUxfj/zBRF7t5TwECcDXbcE34ih RYMh20yQlv+SLt2VhdvBSSuQ== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 76613df5 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 30 Jun 2024 13:51:22 +0200 (CEST) In-Reply-To: <86o77jj470.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Jun 2024 15:58:43 +0300") Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320953 Archived-At: Eli Zaretskii writes: >> From: Michael Albinus >> Cc: manuel@ledu-giraud.fr, rms@gnu.org, emacs-devel@gnu.org, >> jonas@bernoul.li >> Date: Sat, 29 Jun 2024 14:47:07 +0200 >> >> >> TL;DR: I don't believe with-editor is just a bug fix. There are reasons >> >> for the implementation as-it-is. It might profit from using >> >> emacsclient also for the remote case (when possible), but nobody >> >> has taken the stab. >> > >> > I don't see how we can discuss a package which solves problems we >> > don't understand. >> >> Oh, we understand. When there is no emacsclient on the remote host, we >> cannot use it. with-editor solves this problems. > > I meant in the local case. FWIW, I have never yet encountered a case, where having the emacs server started and EDITOR set to "emacsclient" failed in the local case. That said, skimming through the with-editor's code, it seems to try real hard to find a correct emacsclient (even "remacsclient" for remacs!) It even seems to start the emacs server if it is not already the case. So I agree that it could be declared "broken" installations. -- Manuel Giraud