From: Po Lu <luangruo@yahoo.com>
To: Pip Cet <pipcet@protonmail.com>
Cc: Stefan Kangas <stefankangas@gmail.com>,
Emacs Devel <emacs-devel@gnu.org>
Subject: Re: master 2f875ead59a: Avoid magic values in xfont_list
Date: Sat, 20 Jul 2024 21:50:42 +0800 [thread overview]
Message-ID: <87y15wxjd9.fsf@yahoo.com> (raw)
In-Reply-To: <WHxraENQFQkLMgLe4G81DNHOAeyDvystpFprzBSvMBKe3F_mabbfeK5DhqnIdZhMScY4a2gvcysSbyDAaCH0NOvP8fEdOEo61pHgCDnbSz4=@protonmail.com> (Pip Cet's message of "Sat, 20 Jul 2024 13:22:45 +0000")
Pip Cet <pipcet@protonmail.com> writes:
> On Saturday, July 20th, 2024 at 13:13, Stefan Kangas <stefankangas@gmail.com> wrote:
>
>> - char *r = name + len - 9; /* 9 == strlen (iso8859-1) */
>> + char *r = name + len - sizeof "iso8859-1" - 1;
>
> Should there be parentheses around
>
> sizeof "iso8859-1" - 1
>
> maybe? As it is the new code subtracts 11 from name + len, not 9, I believe.
>
> Pip
Right, I just noticed (and fixed) this too. Could we each of us agree
to endeavor to reduce code churn rather than contribute to worsening it?
prev parent reply other threads:[~2024-07-20 13:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172148118852.8008.11424776991367078206@vcs2.savannah.gnu.org>
[not found] ` <20240720131308.EE4B6C3534C@vcs2.savannah.gnu.org>
2024-07-20 13:22 ` master 2f875ead59a: Avoid magic values in xfont_list Pip Cet
2024-07-20 13:50 ` Po Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y15wxjd9.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=pipcet@protonmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.