From: Philip Kaludercic <philipk@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 65380@debbugs.gnu.org, juri@linkov.net
Subject: bug#65380: [PATCH] Add command to copy contents in a diff-mode buffer
Date: Tue, 20 Aug 2024 12:10:01 +0000 [thread overview]
Message-ID: <87y14rv1ie.fsf@posteo.net> (raw)
In-Reply-To: <86le0rwhlx.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 20 Aug 2024 14:36:58 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: juri@linkov.net, 65380@debbugs.gnu.org
>> Date: Mon, 19 Aug 2024 19:34:48 +0000
>>
>> +*** New command 'diff-kill-ring-save'
>> +This command copies out the modified contents out of a diff, without
>> +having to apply it first.
>
> This could be reworded to make the effect of the command more clear.
> For example:
>
> This command copies to the 'kill-ring' a region of text modified
> according to diffs in the current buffer, but without applying the
> diffs to the original text.
Applied
>> If the selected range extends a hunk, the
>> +commands attempts to look up and copy the text between from the
>> +referenced file. ^^^^^^^^^^^^^^^^^
>
> Something is missing (or redundant) in this sentence.
How about "the text in between from". Does that sound better?
^^
>> +(defun diff-kill-ring-save (beg end &optional reverse)
>> + "Save contents of the region between BEG and END akin to `kill-ring-save'.
>
> The first line should IMO say something to make it clear this command
> uses diffs from the current buffer. OTOH, the reference to
> `kill-ring-save' is much less important. So how about
>
> Save to `kill-ring' the result of applying diffs in region between BEG and END.
I like it.
>> +By default the command will copy the text that applying the diff would
>> +produce, along with the text between hunks. If REVERSE is non-nil, or
>> +the command was invoked with a prefix argument, copy the deleted text."
>
> The "deleted text" part here is unclear: who or what deletes text and
> what text is deleted?
I want to express that it copies the parts of the diff, that the
changeset removes (lines beginning with "-"). So perhaps "... copy the text
removed in the diff" would be better?
--
Philip Kaludercic on peregrine
next prev parent reply other threads:[~2024-08-20 12:10 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 9:53 bug#65380: [PATCH] Add command to copy contents in a diff-mode buffer Philip Kaludercic
2023-08-19 10:00 ` Philip Kaludercic
2023-08-20 0:59 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-20 7:52 ` Philip Kaludercic
2023-08-19 10:46 ` Eli Zaretskii
2023-08-19 10:48 ` Philip Kaludercic
2023-08-19 11:06 ` Eli Zaretskii
2023-08-19 15:45 ` Philip Kaludercic
2023-08-19 19:09 ` Eli Zaretskii
2023-08-19 19:30 ` Philip Kaludercic
2023-08-19 21:01 ` Sean Whitton
2023-08-19 22:49 ` Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-20 0:41 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-20 16:30 ` Juri Linkov
2023-08-20 18:17 ` Eli Zaretskii
2023-08-20 18:24 ` Philip Kaludercic
2023-08-20 18:29 ` Eli Zaretskii
2023-08-22 11:06 ` Philip Kaludercic
2023-08-22 11:29 ` Eli Zaretskii
2024-08-17 16:34 ` Philip Kaludercic
2024-08-18 15:29 ` Philip Kaludercic
2024-08-18 15:43 ` Eli Zaretskii
2024-08-18 16:20 ` Philip Kaludercic
2024-08-18 18:00 ` Eli Zaretskii
2024-08-19 19:34 ` Philip Kaludercic
2024-08-20 6:44 ` Juri Linkov
2024-08-20 7:46 ` Philip Kaludercic
2024-08-20 16:53 ` Juri Linkov
2024-08-20 11:36 ` Eli Zaretskii
2024-08-20 12:10 ` Philip Kaludercic [this message]
2024-08-20 13:09 ` Eli Zaretskii
2024-08-20 16:23 ` Philip Kaludercic
2024-08-20 18:43 ` Eli Zaretskii
2024-08-20 21:35 ` Philip Kaludercic
2024-08-21 13:42 ` Eli Zaretskii
2024-08-21 19:40 ` Philip Kaludercic
2024-08-22 3:25 ` Eli Zaretskii
2024-08-22 6:41 ` Philip Kaludercic
2024-08-22 10:22 ` Eli Zaretskii
2024-08-22 18:59 ` Philip Kaludercic
2023-08-20 19:47 ` Jim Porter
2023-08-20 20:13 ` Gregory Heytings
2023-08-20 20:45 ` Jim Porter
2023-08-20 21:29 ` Gregory Heytings
2023-08-20 22:21 ` Jim Porter
2023-08-20 22:31 ` Gregory Heytings
2023-08-20 23:39 ` Gregory Heytings
2023-08-21 0:34 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y14rv1ie.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=65380@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.