From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#73175: 30.0.60; toggling emacs-news-view-mode doesn't remove buttons Date: Wed, 11 Sep 2024 11:42:26 +0200 Message-ID: <87y13yle65.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8017"; mail-complaints-to="usenet@ciao.gmane.io" To: 73175@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 11 11:43:04 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1soJsO-0001u0-B8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Sep 2024 11:43:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1soJsI-00037k-D6; Wed, 11 Sep 2024 05:42:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soJsH-00030g-0R for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 05:42:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1soJsG-0006cA-AJ for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 05:42:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=hG/3jxzigjGv1cWX12TLdw67NxmgTXATmdM22NDkUF0=; b=uCLqlXAAV9amOdtppgPsE3svYjNLFPbyoqs/a4erjmNY0PLqH41gZWuOpBsn3ub5kgV8l0/S7EUYtIBltthMVXPN/CcuOj8EiqEf8y+uLUt4F3xZB4X7hD9HgeyViYWR7TCd3xhhD5VFVwzemS+1sMXHG5zp+KwhS31jpVuHFE4dsEkJ9Ja6oMW+JQUcbUijt6QmqIQJcCqVsPppE3a0gcKL8dBNdV64waTRPxwpBITZysS9VIVptt/0D949dqHhXH/cHOrsPXDDu+Wt2wELnAFhxD7e5+sLM4Qs0+zH3i5oyCce6yFhsUE8CPFBxjJvRGjJbVtCVkoXqwPj+/qfTA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1soJsM-0007Td-Dj for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 05:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Sep 2024 09:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73175 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.172604776428715 (code B ref -1); Wed, 11 Sep 2024 09:43:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Sep 2024 09:42:44 +0000 Original-Received: from localhost ([127.0.0.1]:37793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soJs3-0007T5-Ps for submit@debbugs.gnu.org; Wed, 11 Sep 2024 05:42:44 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:40960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soJs1-0007Sw-SE for submit@debbugs.gnu.org; Wed, 11 Sep 2024 05:42:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soJrr-0007tz-TI for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 05:42:31 -0400 Original-Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1soJrq-0006YK-DW for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 05:42:31 -0400 Original-Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-42ca4e0299eso39041385e9.2 for ; Wed, 11 Sep 2024 02:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726047748; x=1726652548; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=hG/3jxzigjGv1cWX12TLdw67NxmgTXATmdM22NDkUF0=; b=kp+ud4ZbMNfXQP2vhMzX7PxYLYnmkeU+88pvW5l3MLSU0joR1OiAzy1wh76cDMne+p 1VjnrUDhTa/bXn4S4yFy9jrOm/vHWYuYx3hjNC2J1xSW8yQh1yEEeYzCDsqBYRzKMkZf HK+ShAgVoaYb4EC67CgbSOKHJKkEEwdu4V8mPKWNEm5ae/b/m8XiNArJyw1yC4ZJJHD4 BpQ1mVi7bmj+gwpQxYRvCRNUbSj6cJ1kGiM8y76gB8COo2lEhJ0CsZ7RnhEeCWQDw7Fm rJ7Q2Hi0FG5Rq+3hHH1ukHjeYgT2ywDVzQverApnzh0lyA2zEJ8vjtNfOGVk4tpVlC0I s+Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726047748; x=1726652548; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hG/3jxzigjGv1cWX12TLdw67NxmgTXATmdM22NDkUF0=; b=TmM97uqOTqpRVYue94EX2wS2fdL8unI0/PJqDqU1DO30QooXrTWs3y3OB1cG2hLlSL 4nsbKWyr6leYdG3nYznNq4t7GK9/vOwdDRRL4vh/T6VX+u6oBmQfTr3YRn7Gmv/Gm1Un KzMl0HPX7BZk/inWzZJzxma9Qxmqf5jAH+RHBAo+nsOv3YcAsJB/BBh+5O8c886ktnEP JP57LYblNNmQtsswsTPRKXxWmNBy+vBSgrLTSgHT7hRrgU2UQZgxSmGvz83aJJxHFpD/ HfyPq15wdT2bszNcw9EMzJLIUg9Fb98p4y/xs8SqBlD5w10PWiycT+P6AhVGwZ1igjS8 lm6Q== X-Gm-Message-State: AOJu0YxTSwBqFh+NJCTGMjFRhWkaHAlbvKITluMrcXONcv6n6SteXDDF iOLXG2/OVo9xJq/Dw5KoIqpeVFlebtM7edHxd8GGA+SyL2li8CqvKyeMvQ== X-Google-Smtp-Source: AGHT+IHT99hdqrluu4Pe1vd3bOzQJ5jABwqGoT0r7v0UuGsi4lVcwLOHfdfPTyfh+Ow1LsfI2Tt7Mg== X-Received: by 2002:a05:600c:3586:b0:426:50e1:ea6e with SMTP id 5b1f17b1804b1-42cad76a0aamr105215785e9.18.1726047747782; Wed, 11 Sep 2024 02:42:27 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb51:8061:cf5c:603f:ba35]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42caeb81611sm138958695e9.32.2024.09.11.02.42.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Sep 2024 02:42:27 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291593 Archived-At: src/emacs -Q etc/NEWS C-x C-q ; buttons appear C-x C-q ; buttons don=CA=BCt disappear (personally I don=CA=BCt mind the buttons, but the intent of faf1f037987c was to make them disappear). I came up with the following, but I can never remember all the details of text property removal (maybe we need a `button-debuttonize-region'?) diff --git a/lisp/textmodes/emacs-news-mode.el b/lisp/textmodes/emacs-news-= mode.el index edeb1540feb..2cca63071b5 100644 --- a/lisp/textmodes/emacs-news-mode.el +++ b/lisp/textmodes/emacs-news-mode.el @@ -112,10 +112,17 @@ emacs-news--mode-common (define-derived-mode emacs-news-mode text-mode "NEWS" "Major mode for editing the Emacs NEWS file." ;; Disable buttons. - (button-mode nil) + (button-mode -1) ;; And make the buffer writable. This is used when toggling ;; emacs-news-mode. (setq buffer-read-only nil) + (save-excursion + (with-silent-modifications + (widen) + (remove-text-properties (point-min) (point-max) + (button--properties nil nil nil)) + (add-face-text-property (point-min) (point-max) + 'button nil))) (setq-local fill-paragraph-function #'emacs-news--fill-paragraph) (emacs-news--mode-common)) =20 In GNU Emacs 30.0.60 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-09-05 built on rltb Repository revision: fc7581ae2ee9db1e3189b76c66be9cd13f72f004 Repository branch: emacs-30 System Description: Debian GNU/Linux 12 (bookworm) Robert --=20