The erc-nicks module does not respect erc-pal-face and erc-fool-face
when assigning a face for a nick, specifically when a user writes a
message that includes a nick of a pal or fool, leading to the faces
being different in the nick tag (<your_nick>) and the message
(ex. "your_nick: hi").

Reproduction config:

   (use-package erc
     :defer t
     :config
     (custom-set-faces
      `(erc-pal-face ((t (:foreground "red")))))
     (setopt erc-modules
             (seq-union '(nicks) erc-modules))
     :custom
     (erc-nicks-colors '("yellow"))
     (erc-pals '("trev")))
   
In the above config, you will notice that "<trev>" will be red, but when
someone mentions "trev" in a message, the nick will be yellow (instead
of red).

Attached is a proposed patch. Feedback needed and welcome!