From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] Proposal to add consult-dir to ELPA Date: Sat, 16 Nov 2024 01:01:25 +0000 Message-ID: <87y11kuh3u.fsf@posteo.net> References: <87ldxmmmlo.fsf@gmail.com> <87sertdspv.fsf@posteo.net> <878qtke2pv.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19112"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Karthik Chikmagalur Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 16 02:02:45 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tC7D3-0004j3-Id for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Nov 2024 02:02:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tC7C6-0004Bo-CO; Fri, 15 Nov 2024 20:01:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tC7Bw-0004BR-Qh for emacs-devel@gnu.org; Fri, 15 Nov 2024 20:01:37 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tC7Bu-00089U-Fc for emacs-devel@gnu.org; Fri, 15 Nov 2024 20:01:36 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5A83C240101 for ; Sat, 16 Nov 2024 02:01:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1731718887; bh=UTbGO5ENDtFGCQrOSrfSC6bVKfYV+adgKQrTPa4z/N4=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=LbLjukTVvSV2aucPw95X5nOoAqWvi+WGqhpy27sm/G5JG3CuBD9nvBOFWiYjF9L4u CFMYTF8wbUkzTb6q6Hh0rCGZYMEI6jJPAzzyedyomtVaVwsTsHx4DT3N3jInA3iwkP 8Wak92CcMPVIdiL3NHkCVginksmX+/78SftcK6rGg8n+Kd+L6HuEg1Ieacds5lYvXB OvKGdzuOnO8XvPMfQqKNw3dxvBD6oYogcLDhgbvjlHRfGqzredLcpKyvkG3oHKQyZf F9kAE+soztbmn7qyER6oNP4aPqQlfE1jphfbY4c2X2HAdl0kW/e2zukY3Psf5uiVLe Bu3Sv/mR/qHFA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XqwZG2vLVz9rxD; Sat, 16 Nov 2024 02:01:26 +0100 (CET) In-Reply-To: <878qtke2pv.fsf@gmail.com> (Karthik Chikmagalur's message of "Fri, 15 Nov 2024 11:06:36 -0800") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325468 Archived-At: Karthik Chikmagalur writes: > Thanks for the review, I'll apply your suggestions and get back to you > when I can. > >>> I have found it to be a surprisingly versatile tool, and many users have >>> told me over the years that it solves a problem they didn't realize they >>> had. >> >> What is not clear to me is why this is not a part of Consult, if it is >> as useful as you say. Have you discussed this with Daniel? In any >> case, it would be useful to explain that somewhere. > > This discussion was had in > https://github.com/minad/consult/issues/373#issuecomment-889841426. > > The conclusion was that it would be better to have this be a separate > package. Here is the relevant part of the exchange: > >> DANIEL: ...I am not sure. And since Omar still has his bookmark >> directory jumper, there is probably a need for such a feature. Maybe >> one should also reconsider adding some new commands to Consult itself >> which fill the gap. Generally I am hesitant to stuff much more >> functionality into Consult itself, but a directory selection command >> does not sound unreasonable. >> >> ME: If you're interested in adding this to Consult, I can submit a >> PR. I'm okay with it living in a separate package though. >> >> DANIEL: Currently not, since I don't have a clear picture of what I >> want. But if it turns out that we find something small and generic I >> would be happy to add it. But adding multiple new sources, many commands >> etc, does not seem to me like a good idea at this point. I'd rather >> modularize the ecosystem more. Right now Consult is already pretty much >> a kitchen sink, but my general guideline is to maintain mostly reusable >> components here. For example consult-org-heading is a generic Org >> jumper, and you can glue it together with other commands or with Embark >> in order to get richer actions on the headings. Another example is the >> recently added consult-line-multi, which allows you to specify a query >> argument to restrict the set of buffers. This way I avoid having to add >> more special consult-line-all-buffers-of-this-and-that-type style >> commands. This conversation is from 2021, and you are saying this is still the state of the discussion? Just to be clear, it doesn't matter much either way, I just want to make sure there is no latent interest in merging the two packages. >>> I have signed the copyright papers, and there are no contributions to >>> the project from users over 3-4 lines in length. Consult-dir's only >>> external dependency (Consult) is in ELPA. >> >> 1+ (though I have suggested to depend on project so as to lower the >> dependency on Emacs). > > Why is adding another dependency a good idea? Isn't Emacs guaranteed to > ship a supported version of `package.el'? Yes, but IIRC the functionality you were using was not available in Emacs 26, but you could install a newer version from ELPA with the missing functionality. > Karthik -- Philip Kaludercic on siskin