From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 7c50e4cc8cc 2/2: Improve 'compilation-transform-file-match-alist' documentation Date: Wed, 04 Dec 2024 16:08:23 +0100 Message-ID: <87y10vcwpk.fsf@gmail.com> References: <173332205449.2846597.9153784089592444113@vcs3.savannah.gnu.org> <20241204142055.B1FEF5430D0@vcs3.savannah.gnu.org> <877c8feda3.fsf@gmail.com> <86v7vzzed7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3433"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 04 16:09:36 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIr0R-0000kj-T7 for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Dec 2024 16:09:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIqzO-000126-55; Wed, 04 Dec 2024 10:08:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIqzN-00011y-Es for emacs-devel@gnu.org; Wed, 04 Dec 2024 10:08:29 -0500 Original-Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIqzL-0005WA-Uu; Wed, 04 Dec 2024 10:08:29 -0500 Original-Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-434a45f05feso84447755e9.3; Wed, 04 Dec 2024 07:08:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733324905; x=1733929705; darn=gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=pQYFe23j8ZZs/JGHT8cPL/WJ3Jp4GmwI8kUJDTs5xNY=; b=eFywBbOQJAFeX0oHgYKvTILUM03/v2JLGPQ0XkU5dADJDzSDZxl79M68wNy8LDifIP dEja1kTKQn5f3DWxOHOUooAV+4MqO3Nv4laSuzUhqiXkjMQMIaURsdpxBvCSEvLsaJsp VWe57vGzYVwN0olrNi3cuyC8PBGn/zOzBy4LEAvs1FQf/KVuVs4BkXrSL81vgf7RfK5d B8FlbpY4qfAleHlhQdI6je7hyGEmwfGCnoYjPTIFEoLzwXpbK/NQE07lEIcO1Nkrls1i LvFRrZbtm5kqNufoFVe4lk7Z0JDauagmV8aDsLFWB6kESQxoAMUnMKsKrKMxIj9/mm4I dA3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733324905; x=1733929705; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pQYFe23j8ZZs/JGHT8cPL/WJ3Jp4GmwI8kUJDTs5xNY=; b=H4l8tKjORkmhQbOSd3eaRLEcJi9zQqiKr72aoNbF6EU6+Be9h0nRpMWiD3SbL6nY6N h+fEWLT217WI5sI8ri0rw5Fr64lrJ4J2jK7P8h1eH76Y48CPg1sUYDCl27cfmBBONrLW Th9Bmb/HgsEGGYVQAQqSanLB0G+B3jZCSTbmTxPuMWaXyp4gkvvHJ6F2Bal0szVvavWM Ak2c6tWJC+RAslUV90A9xBnyYEsVEfrMexU2eBhLtaxxNamy21gN6NHnPnFfKnxoH4Kx xBWxKVy8ms6E/wUbU6DJ79vKzfO3IVDFILgXAztS/rgNfzUxyxVFS8wBGfbP5mp7AX6J yXtQ== X-Gm-Message-State: AOJu0YzSeLnwTMr2jc2Or3bWVyV4aIjYjQxdph9FJE41Q2nWm9WAlziY f0C3itvNMDO7JWOBpPoRSdEarWZYwODNoR/QO0l13JHFpmj003t80LG9JA== X-Gm-Gg: ASbGncv01HfEMvB/pS4w42c32ZMeYM4WSCYTrhy49hwsH8P4zCbYIWeMAAsyCzU8p0S kPM2Y2o3/1DcsHOUgKaGav2LSl7KRrkitn3/RAYQzuJhkfeSYn6uhHpFLDQmVVI6B4egthSf/hu kjgzeV8ZFgJTc6PHJO6GOlAyYHYrotWDBtf83jQA2ZLDD3GDy9cwEOMDdy/6oqEkFtEUIBW7W1M rGPqStZDRoz90+y4ILh60qfn7XLbcEbjokIDQ== X-Google-Smtp-Source: AGHT+IFIOfddLRNNi1hrK+9mngjnYTuRD7NTGbIoizGaPWQolEs+hkrl6LWXwYS0KNzufvTslB+/Iw== X-Received: by 2002:a05:600c:35c2:b0:434:a781:f5d9 with SMTP id 5b1f17b1804b1-434d09c11d7mr64842395e9.11.1733324904819; Wed, 04 Dec 2024 07:08:24 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb51:b3e6:15b0:9869:5220]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434d52cbd42sm27370555e9.38.2024.12.04.07.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2024 07:08:24 -0800 (PST) In-Reply-To: <86v7vzzed7.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 04 Dec 2024 16:56:04 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=rpluim@gmail.com; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326032 Archived-At: >>>>> On Wed, 04 Dec 2024 16:56:04 +0200, Eli Zaretskii said: Eli> I don't think I'd mind to install on emacs-30, but if we are doing Eli> this, why not do a better job? The tags above are not quite clear, to Eli> say the least. "Match"? "Replace with"? does that really explain Eli> itself? The docstring is supposed to explain it :-) How about: diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index ee7fc6aaecb..99385fcca07 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -77,8 +77,9 @@ compilation-transform-file-match-alist Similarly, to remove a prefix \"bar/\", use: (\"\\\\=`bar/\" \"\")" - :type '(repeat (list regexp (choice (const :tag "No replacement" nil) - string))) + :type '(repeat (list (regexp :tag "Match filename(s)") + (radio (const :tag "Not an error" nil) + (string :tag "Replace match with")))) :version "27.1") (defvar compilation-filter-hook nil Robert --