From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Steven Allen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74902: 31.0.50; Segfault when deleting frames Date: Tue, 31 Dec 2024 08:53:23 -0800 Message-ID: <87y0zveqv0.fsf@stebalien.com> References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> Reply-To: Steven Allen Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33104"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74902@debbugs.gnu.org To: Robert Pluim , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 31 17:54:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSfVX-0008SV-QF for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Dec 2024 17:54:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSfVM-000264-DD; Tue, 31 Dec 2024 11:54:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSfVK-00025r-Lf for bug-gnu-emacs@gnu.org; Tue, 31 Dec 2024 11:54:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tSfVK-0007ec-DG for bug-gnu-emacs@gnu.org; Tue, 31 Dec 2024 11:54:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=4q2gm99EqpskYaPlTSf16+qXIHB90PV2vgBfwjwYTXA=; b=SfESzVlUea7qjexAzYTs/9xUDAmB+MOIywTP40vIHzxFV9m/ty4GXWS4jIwDQ3MnMnPGfNluCxBDeIUkCKTmgHj43SJfhyOqSOtbM0ptLRM2fzdQKbWKZWDbuYpc5y9LvmqrcAztSBnonPE+lTHMlbP24Xq3Kv+fiOTx1DuwfUgN+HokHkEFI4KI9v9961Vj2HLv/UDewe7C3Ks4mJBr+GMaOqHhzk6NZGapmUtTr5dLY0kesjEAnBzlLYGqzbLXYpwcDF6RPasomtds977lulQhPMRogMJA8V6WWcXXcpH4xoBk26qfhT9ojMBnzbA5DVBtOcuYK0N4SLAiVqp6IA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tSfVK-0005Eh-1A for bug-gnu-emacs@gnu.org; Tue, 31 Dec 2024 11:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Dec 2024 16:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74902 X-GNU-PR-Package: emacs Original-Received: via spool by 74902-submit@debbugs.gnu.org id=B74902.173566401320077 (code B ref 74902); Tue, 31 Dec 2024 16:54:01 +0000 Original-Received: (at 74902) by debbugs.gnu.org; 31 Dec 2024 16:53:33 +0000 Original-Received: from localhost ([127.0.0.1]:36634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSfUq-0005Dl-T5 for submit@debbugs.gnu.org; Tue, 31 Dec 2024 11:53:33 -0500 Original-Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]:46285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSfUo-0005DX-GR for 74902@debbugs.gnu.org; Tue, 31 Dec 2024 11:53:30 -0500 Original-Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.phl.internal (Postfix) with ESMTP id 642451140189; Tue, 31 Dec 2024 11:53:25 -0500 (EST) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Tue, 31 Dec 2024 11:53:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1735664005; x= 1735750405; bh=4q2gm99EqpskYaPlTSf16+qXIHB90PV2vgBfwjwYTXA=; b=n Nxqpl+AA6WHL4plysAV6UXVBgug6OtJ9A2FI3/kc0Ld6bgsVs1GQvXTYiPG1uM58 KoNcg2aW14ExcEBuYVwGuA6ft9UsN62bxVC1h2vzjBb0ga1b7xWmAvLoRgOwtxt5 k2MJdZJLCUOPcuXNwZZ2gjfhXEpg4jglRFy4mj1BPtlB2/uKkQ9TvTaeDQaCtAwH muW3AUkucB1KK6qU4xb7XBbQN3V//loSFSkUBbVdeb57N2L+wRf8vegjBM3g2icY iwfXM3QNzv1Si8e3mLcjlH5s4ZoduqKy3iq6fJpncyja/S60ucleQuF6+IW/St5s Tp6NN0e0HrxwdHmsUxQFQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1735664005; x=1735750405; bh=4q2gm99EqpskYaPlTSf16+qXIHB90PV2vgB fwjwYTXA=; b=kYqkUCnC6V5k3GXrNYCTBULowRFDanJzsTMwI54t5nxaQD2HqIJ HpuG3HFZLhGQZVii2gd4miWT1eKO6bwW8u/Rh6Ky6Kgi516Vc2h6XhpdKwGJ+Yos QaKlG++nixL60RZggqYtIrlD4Qa5l/7hBVn20kHGVQjOBnMIxLq5tRpPREZ61EbU Sy1KjchN7sOuN2EJZ2AD6Abx/6PlkO2afGr42LA7LXw8nWxmA6ehJzR9JPYDuxHi qJjdkl1T9n8mYAEGg1fNz+HXg1ZgqeRZ+wulpDavd9oZ0E8Dho8kFJTiL3yDnWvE D9VO488Wqxg4T6QeCsXMAgz/QaLAlUr5cjA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddvkedgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehttdertddttddtnecu hfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnh drtghomheqnecuggftrfgrthhtvghrnhepvdekheekgeelheehgefgudelkeethffhgfeu ffetkeegtddvfeduuddttdejjedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmpdhnsggp rhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehrphhluhhimh esghhmrghilhdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphht thhopeejgeeltddvseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 31 Dec 2024 11:53:24 -0500 (EST) In-Reply-To: <87frmn5yu5.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298049 Archived-At: Robert Pluim writes: > If you do find a reproducer, then based on the trace above I think the > following should fix it: > > diff --git a/src/frame.c b/src/frame.c > index f6053fca3ef..ff9e1d24ea1 100644 > --- a/src/frame.c > +++ b/src/frame.c > @@ -2281,7 +2281,9 @@ delete_frame (Lisp_Object frame, Lisp_Object force) > delete_all_child_windows (f->root_window); > fset_root_window (f, Qnil); > > + block_input(); > Vframe_list = Fdelq (frame, Vframe_list); > + unblock_input(); > SET_FRAME_VISIBLE (f, 0); > > /* Allow the vector of menu bar contents to be freed in the next >From what I can tell (my reproducer isn't 100% effective), this does indeed fix the issue. Thanks!