From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Last steps for pretesting (font-lock-extend-region-function) Date: Mon, 24 Apr 2006 17:20:48 -0400 Message-ID: <87wtdeel1y.fsf-monnier+emacs@gnu.org> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1145913704 15245 80.91.229.2 (24 Apr 2006 21:21:44 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 24 Apr 2006 21:21:44 +0000 (UTC) Cc: Richard Stallman , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 24 23:21:38 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FY8Ue-0006AN-5b for ged-emacs-devel@m.gmane.org; Mon, 24 Apr 2006 23:21:16 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FY8Ud-0005r0-JI for ged-emacs-devel@m.gmane.org; Mon, 24 Apr 2006 17:21:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FY8UT-0005pq-H9 for emacs-devel@gnu.org; Mon, 24 Apr 2006 17:21:05 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FY8US-0005oV-44 for emacs-devel@gnu.org; Mon, 24 Apr 2006 17:21:05 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FY8UR-0005oQ-VY for emacs-devel@gnu.org; Mon, 24 Apr 2006 17:21:03 -0400 Original-Received: from [209.226.175.4] (helo=tomts16-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FY8WX-0006Rr-P4; Mon, 24 Apr 2006 17:23:14 -0400 Original-Received: from alfajor ([70.55.144.118]) by tomts16-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20060424212048.FBQZ27612.tomts16-srv.bellnexxia.net@alfajor>; Mon, 24 Apr 2006 17:20:48 -0400 Original-Received: by alfajor (Postfix, from userid 1000) id A1332D7855; Mon, 24 Apr 2006 17:20:48 -0400 (EDT) Original-To: Alan Mackenzie In-Reply-To: (Alan Mackenzie's message of "Mon, 24 Apr 2006 19:28:44 +0000 (GMT)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53357 Archived-At: > I say to you again - your solution is not robust. I don't think it's > been tried at all (correct me if I'm wrong). Of course it has, in smerge-mode (since Emacs-21.1) which I use daily, in cvs-status (since Emacs-21.1) in perl-mode (since some time in late 2004 IIRC), in sh-script.el (a bit before perl-mode IIRC), in message.el (where it's been buggy at times because I didn't understand that I needed a font-lock-default-fontify-region hook). They do all suffer from the missing font-lock-default-fontify-region hook, just like your code, of course. > So - please leave the better tested mechanism in place. I don't claim it's buggy or even more buggy than font-lock-multiline. It's just an ugly kludge, much more heavyweight codewise (this is objectively the case in terms of lines of code, and I hope my comparison above convinces a few more people that it's also subjectively the case). Stefan