From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Hansen Newsgroups: gmane.emacs.devel Subject: Re: occur and a "Special" *Occur* Buffer. Date: Tue, 27 Mar 2007 06:17:01 +0200 Organization: disorganized Message-ID: <87wt13s4le.fsf@localhorst.mine.nu> References: <87hcsuao1j.fsf@localhorst.mine.nu> <87ircou43e.fsf@localhorst.mine.nu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1174969422 25468 80.91.229.12 (27 Mar 2007 04:23:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 27 Mar 2007 04:23:42 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 27 06:23:36 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HW3Dc-0002xT-4m for ged-emacs-devel@m.gmane.org; Tue, 27 Mar 2007 06:23:36 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HW3Ft-0004S6-Ig for ged-emacs-devel@m.gmane.org; Mon, 26 Mar 2007 23:25:57 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HW3Fq-0004S0-OV for emacs-devel@gnu.org; Tue, 27 Mar 2007 00:25:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HW3Fp-0004Rj-3P for emacs-devel@gnu.org; Tue, 27 Mar 2007 00:25:54 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HW3Fo-0004Rb-TI for emacs-devel@gnu.org; Mon, 26 Mar 2007 23:25:52 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HW3DT-0006nw-H8 for emacs-devel@gnu.org; Tue, 27 Mar 2007 00:23:28 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1HW3DH-00056k-2z for emacs-devel@gnu.org; Tue, 27 Mar 2007 06:23:15 +0200 Original-Received: from e178025065.adsl.alicedsl.de ([85.178.25.65]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 27 Mar 2007 06:23:15 +0200 Original-Received: from david.hansen by e178025065.adsl.alicedsl.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 27 Mar 2007 06:23:15 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 58 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: e178025065.adsl.alicedsl.de Mail-Copies-To: nobody User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.95 (gnu/linux) Cancel-Lock: sha1:ufCK4xNlrFV+CwUmduCGhpbBhdQ= X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68656 Archived-At: On Mon, 26 Mar 2007 11:10:46 -0400 Stefan Monnier wrote: >>>> another one. Is no one else using special display buffers? BTW in >>>> this case `t' seems to be the right choice for the optional >>>> `get-buffer-window' argument, but i have to admit that i don't >>>> really understand it ;) >>> >>> Imagine that t means "any frame, even if it's displayed in my other office", >>> whereas 0 means "any frame so long as I might get to see it very soon". >>> So, yes, in this case I think t is just as good. But the code should be >>> fixed to handle the case where the occur buffer is not displayed in >>> *any* window. > >> How to get these "special buffer" fixes applied? Shall I send one >> patch summarizing it? Assignment should be there at the time >> (where's my $1?). > > Oh, they may have just fallen through. I thought someone else installed > them. I just installed a fix for the occur-next-error case. If there's > some other fix that's still pending, please resend it, thank you. And sorry > for the delay. Here are the two others: Index: lisp/comint.el =================================================================== RCS file: /sources/emacs/emacs/lisp/comint.el,v retrieving revision 1.359 diff -u -r1.359 comint.el --- lisp/comint.el 17 Mar 2007 18:08:50 -0000 1.359 +++ lisp/comint.el 27 Mar 2007 04:15:16 -0000 @@ -2959,7 +2959,7 @@ (defun comint-dynamic-list-completions (completions) "List in help buffer sorted COMPLETIONS. Typing SPC flushes the help buffer." - (let ((window (get-buffer-window "*Completions*"))) + (let ((window (get-buffer-window "*Completions*" 0))) (setq completions (sort completions 'string-lessp)) (if (and (eq last-command this-command) window (window-live-p window) (window-buffer window) Index: lisp/emacs-lisp/lisp.el =================================================================== RCS file: /sources/emacs/emacs/lisp/emacs-lisp/lisp.el,v retrieving revision 1.78 diff -u -r1.78 lisp.el --- lisp/emacs-lisp/lisp.el 21 Jan 2007 02:44:24 -0000 1.78 +++ lisp/emacs-lisp/lisp.el 27 Mar 2007 04:16:25 -0000 @@ -583,7 +583,7 @@ considered." (interactive) - (let ((window (get-buffer-window "*Completions*"))) + (let ((window (get-buffer-window "*Completions*" 0))) (if (and (eq last-command this-command) window (window-live-p window) (window-buffer window) (buffer-name (window-buffer window)))