From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Phil Hagelberg Newsgroups: gmane.emacs.devel Subject: Re: Hyperlinks in *vc-change-log* Date: Fri, 11 Apr 2008 23:44:23 -0700 Message-ID: <87wsn3y3lk.fsf@hagelb.org> References: <87fxtvng9t.fsf@hagelb.org> <874pa9djro.fsf@hagelb.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1207982683 26283 80.91.229.12 (12 Apr 2008 06:44:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Apr 2008 06:44:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 12 08:45:15 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JkZUA-0001Qq-Gy for ged-emacs-devel@m.gmane.org; Sat, 12 Apr 2008 08:45:14 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JkZTW-0002C7-FT for ged-emacs-devel@m.gmane.org; Sat, 12 Apr 2008 02:44:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JkZTS-0002By-0Y for emacs-devel@gnu.org; Sat, 12 Apr 2008 02:44:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JkZTR-0002BX-0B for emacs-devel@gnu.org; Sat, 12 Apr 2008 02:44:29 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JkZTQ-0002BU-OK for emacs-devel@gnu.org; Sat, 12 Apr 2008 02:44:28 -0400 Original-Received: from sd-green-bigip-207.dreamhost.com ([208.97.132.207] helo=spunkymail-a4.g.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JkZTQ-0008Af-Ci for emacs-devel@gnu.org; Sat, 12 Apr 2008 02:44:28 -0400 Original-Received: from dynabook (75-172-34-195.tukw.qwest.net [75.172.34.195]) by spunkymail-a4.g.dreamhost.com (Postfix) with ESMTP id 877703B9EC; Fri, 11 Apr 2008 23:44:23 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Fri, 11 Apr 2008 12:36:59 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95016 Archived-At: Stefan Monnier writes: >> But I'm not sure how that would work in terms of the UI. This is all >> implemented using buttons, so I am only tying functionality to text >> that already exists in the buffer. Perhaps another binding could be >> used? RET to visit a revision, and C-RET to view the diff between that >> revision and the last? > > I was thinking of a menu. From the keyboard we already have bindings > for those operations, IIRC (at least `d' for the diff). I actually realized that the whole of what I wanted when I wrote that code is already present in log-view.el. I just assumed that RET would be the binding for visiting the revision under the point, but it's actually bound to 'f'. I'd suggest that RET be bound to log-view-find-revision in log-view-mode. This just seems much more obvious to me. > For multifile logs, the best option would be to popup a menu of files. > BTW this is specific to the display of files. For `diffs', this problem > wouldn't occur. It turns out the current implementation of log-view-diff only diffs one file in the fileset, so this could be fixed. In addition giving a menu in the minibuffer for log-view-find-revision on filesets seems like a good idea. I will work on implementing these. -Phil http://technomancy.us