all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Phil Hagelberg <phil@hagelb.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Hyperlinks in *vc-change-log*
Date: Fri, 11 Apr 2008 23:44:23 -0700	[thread overview]
Message-ID: <87wsn3y3lk.fsf@hagelb.org> (raw)
In-Reply-To: <jwvprswxskq.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 11 Apr 2008 12:36:59 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> But I'm not sure how that would work in terms of the UI.  This is all
>> implemented using buttons, so I am only tying functionality to text
>> that already exists in the buffer.  Perhaps another binding could be
>> used?  RET to visit a revision, and C-RET to view the diff between that
>> revision and the last?
>
> I was thinking of a menu.  From the keyboard we already have bindings
> for those operations, IIRC (at least `d' for the diff).

I actually realized that the whole of what I wanted when I wrote that
code is already present in log-view.el. I just assumed that RET would be
the binding for visiting the revision under the point, but it's actually
bound to 'f'. I'd suggest that RET be bound to log-view-find-revision in
log-view-mode. This just seems much more obvious to me.

> For multifile logs, the best option would be to popup a menu of files.
> BTW this is specific to the display of files.  For `diffs', this problem
> wouldn't occur.  

It turns out the current implementation of log-view-diff only diffs one
file in the fileset, so this could be fixed. In addition giving a menu
in the minibuffer for log-view-find-revision on filesets seems like a
good idea. I will work on implementing these.

-Phil

http://technomancy.us




  reply	other threads:[~2008-04-12  6:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-09 16:29 Hyperlinks in *vc-change-log* Phil Hagelberg
2008-04-09 17:43 ` Lennart Borgman (gmail)
2008-04-09 19:59 ` Stefan Monnier
2008-04-10  7:37   ` Dan Nicolaescu
2008-04-11  5:48   ` Phil Hagelberg
2008-04-11 16:36     ` Stefan Monnier
2008-04-12  6:44       ` Phil Hagelberg [this message]
2008-04-13 17:33     ` Thien-Thi Nguyen
2008-04-15 22:33     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wsn3y3lk.fsf@hagelb.org \
    --to=phil@hagelb.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.