bug#955: edmacro stores illegal macro

bug#955: edmacro stores illegal macro

[matsuyama]

Hi, all.

When I save the macro by typing `C-c C-c' in *Edit Macro*, edmacro doesn't store the macro correctly.

Reproduce:
  M-: (setq last-kbd-macro
        [?\M-x ?e ?v ?a ?l ?- ?e ?x ?p ?r ?e ?s ?s ?i ?o ?n ?\C-m])
  C-x C-k e RET C-c C-c
  M-x insert-kbd-macro
  => (setq last-kbd-macro
       [<eval-expression ?>]) ;; this macro is incorrect
  
I've fixed this problem like that:

--- edmacro.el.orig     2008-09-10 17:01:42.000000000 +0900
+++ edmacro.el  2008-09-10 17:04:05.000000000 +0900
@@ -697,7 +697,7 @@
             (times 1)
             key)
        ;; Try to catch events of the form "<as df>".
-       (if (string-match "^<[^ >\t\n\f][^>\t\n\f]*>" word)
+       (if (string-match "^<[^ >\t\n\f][^>\t\n\f]*>?>" word)
            (setq word (match-string 0 word)
                  pos (+ word-beg (match-end 0)))
          (setq word (substring string word-beg word-end)

After applying this patch, `M-x insert-kbd-macro' works fine.

  M-x insert-kbd-macro
  => (setq last-kbd-macro
       [?\M-x ?e ?v ?a ?l ?- ?e ?x ?p ?r ?e ?s ?s ?i ?o ?n ?\C-m])
       ;; now correct

Thanks.

MATSUYAMA

bug#955: marked as done (edmacro stores illegal macro)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 815 bytes --]


Your message dated Wed, 10 Sep 2008 17:55:42 -0400
with message-id <874p4nmzs1.fsf@cyd.mit.edu>
and subject line Re: edmacro stores illegal macro
has caused the Emacs bug report #955,
regarding edmacro stores illegal macro
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
955: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=955
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3193 bytes --]

From: matsuyama@ariel-networks.com
To: bug-gnu-emacs@gnu.org
Subject: edmacro stores illegal macro
Date: Wed, 10 Sep 2008 17:25:08 +0900
Message-ID: <87wshk2ysb.wl%matsuyama@ariel-networks.com>

Hi, all.

When I save the macro by typing `C-c C-c' in *Edit Macro*, edmacro doesn't store the macro correctly.

Reproduce:
  M-: (setq last-kbd-macro
        [?\M-x ?e ?v ?a ?l ?- ?e ?x ?p ?r ?e ?s ?s ?i ?o ?n ?\C-m])
  C-x C-k e RET C-c C-c
  M-x insert-kbd-macro
  => (setq last-kbd-macro
       [<eval-expression ?>]) ;; this macro is incorrect
  
I've fixed this problem like that:

--- edmacro.el.orig     2008-09-10 17:01:42.000000000 +0900
+++ edmacro.el  2008-09-10 17:04:05.000000000 +0900
@@ -697,7 +697,7 @@
             (times 1)
             key)
        ;; Try to catch events of the form "<as df>".
-       (if (string-match "^<[^ >\t\n\f][^>\t\n\f]*>" word)
+       (if (string-match "^<[^ >\t\n\f][^>\t\n\f]*>?>" word)
            (setq word (match-string 0 word)
                  pos (+ word-beg (match-end 0)))
          (setq word (substring string word-beg word-end)

After applying this patch, `M-x insert-kbd-macro' works fine.

  M-x insert-kbd-macro
  => (setq last-kbd-macro
       [?\M-x ?e ?v ?a ?l ?- ?e ?x ?p ?r ?e ?s ?s ?i ?o ?n ?\C-m])
       ;; now correct

Thanks.

MATSUYAMA




[-- Attachment #3: Type: message/rfc822, Size: 1122 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: matsuyama@ariel-networks.com
Cc: 955-done@emacsbugs.donarmstrong.com
Subject: Re: edmacro stores illegal macro
Date: Wed, 10 Sep 2008 17:55:42 -0400
Message-ID: <874p4nmzs1.fsf@cyd.mit.edu>

> When I save the macro by typing `C-c C-c' in *Edit Macro*, edmacro
> doesn't store the macro correctly.

Thanks for reporting this problem.  I've checked in a similar fix to
what you proposed.