all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: matsuyama@ariel-networks.com
To: bug-gnu-emacs@gnu.org
Subject: bug#955: edmacro stores illegal macro
Date: Wed, 10 Sep 2008 17:25:08 +0900	[thread overview]
Message-ID: <87wshk2ysb.wl%matsuyama@ariel-networks.com> (raw)

Hi, all.

When I save the macro by typing `C-c C-c' in *Edit Macro*, edmacro doesn't store the macro correctly.

Reproduce:
  M-: (setq last-kbd-macro
        [?\M-x ?e ?v ?a ?l ?- ?e ?x ?p ?r ?e ?s ?s ?i ?o ?n ?\C-m])
  C-x C-k e RET C-c C-c
  M-x insert-kbd-macro
  => (setq last-kbd-macro
       [<eval-expression ?>]) ;; this macro is incorrect
  
I've fixed this problem like that:

--- edmacro.el.orig     2008-09-10 17:01:42.000000000 +0900
+++ edmacro.el  2008-09-10 17:04:05.000000000 +0900
@@ -697,7 +697,7 @@
             (times 1)
             key)
        ;; Try to catch events of the form "<as df>".
-       (if (string-match "^<[^ >\t\n\f][^>\t\n\f]*>" word)
+       (if (string-match "^<[^ >\t\n\f][^>\t\n\f]*>?>" word)
            (setq word (match-string 0 word)
                  pos (+ word-beg (match-end 0)))
          (setq word (substring string word-beg word-end)

After applying this patch, `M-x insert-kbd-macro' works fine.

  M-x insert-kbd-macro
  => (setq last-kbd-macro
       [?\M-x ?e ?v ?a ?l ?- ?e ?x ?p ?r ?e ?s ?s ?i ?o ?n ?\C-m])
       ;; now correct

Thanks.

MATSUYAMA







             reply	other threads:[~2008-09-10  8:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <874p4nmzs1.fsf@cyd.mit.edu>
2008-09-10  8:25 ` matsuyama [this message]
2008-09-10 22:00   ` bug#955: marked as done (edmacro stores illegal macro) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wshk2ysb.wl%matsuyama@ariel-networks.com \
    --to=matsuyama@ariel-networks.com \
    --cc=955@emacsbugs.donarmstrong.com \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.