From: Chong Yidong <cyd@stupidchicken.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 3659@emacsbugs.donarmstrong.com, Simon.Marshall@misys.com
Subject: bug#3659: FW: 23.0.95; crash on set-frame-font
Date: Fri, 26 Jun 2009 23:18:21 -0400 [thread overview]
Message-ID: <87ws6y2wle.fsf@stupidchicken.com> (raw)
In-Reply-To: <nkskhm9yyp.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 26 Jun 2009 22:45:18 -0400")
Glenn Morris <rgm@gnu.org> writes:
> "xftfont" is always 0 (perhaps I am printing it wrong? I use "pp".)
Does the following patch prevent the crash?
*** trunk/src/xftfont.c.~1.24.~ 2009-05-11 12:06:41.000000000 -0400
--- trunk/src/xftfont.c 2009-06-26 23:15:32.000000000 -0400
***************
*** 287,300 ****
match = XftFontMatch (display, FRAME_X_SCREEN_NUMBER (f), pat, &result);
FcPatternDestroy (pat);
xftfont = XftFontOpenPattern (display, match);
- ft_face = XftLockFace (xftfont);
- UNBLOCK_INPUT;
-
if (! xftfont)
{
XftPatternDestroy (match);
return Qnil;
}
/* We should not destroy PAT here because it is kept in XFTFONT and
destroyed automatically when XFTFONT is closed. */
font_object = font_make_object (VECSIZE (struct xftfont_info), entity, size);
--- 287,301 ----
match = XftFontMatch (display, FRAME_X_SCREEN_NUMBER (f), pat, &result);
FcPatternDestroy (pat);
xftfont = XftFontOpenPattern (display, match);
if (! xftfont)
{
+ UNBLOCK_INPUT;
XftPatternDestroy (match);
return Qnil;
}
+ ft_face = XftLockFace (xftfont);
+ UNBLOCK_INPUT;
+
/* We should not destroy PAT here because it is kept in XFTFONT and
destroyed automatically when XFTFONT is closed. */
font_object = font_make_object (VECSIZE (struct xftfont_info), entity, size);
next prev parent reply other threads:[~2009-06-27 3:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <63C2A154B1708946B60726AFDBA00AC005E5EC5A@ukmailemea01.misys.global.ad>
[not found] ` <87iqinxbs7.fsf@stupidchicken.com>
[not found] ` <63C2A154B1708946B60726AFDBA00AC005EABBA6@ukmailemea01.misys.global.ad>
[not found] ` <87fxdp4ssu.fsf@stupidchicken.com>
[not found] ` <E1MJdlh-0002uT-DA@etlken>
2009-06-25 3:35 ` bug#3659: FW: 23.0.95; crash on set-frame-font Chong Yidong
2009-06-25 6:16 ` Kenichi Handa
2009-06-25 18:32 ` Glenn Morris
2009-06-27 1:13 ` Kenichi Handa
2009-06-27 2:45 ` Glenn Morris
2009-06-27 3:18 ` Chong Yidong [this message]
2009-06-28 1:11 ` Glenn Morris
2009-06-28 5:24 ` Chong Yidong
2009-06-29 2:24 ` Kenichi Handa
2009-06-29 6:44 ` Glenn Morris
2009-06-29 7:24 ` Kenichi Handa
2009-06-29 18:34 ` Glenn Morris
2009-06-30 0:45 ` Kenichi Handa
2009-06-30 22:26 ` Glenn Morris
2009-07-09 8:25 ` Marshall, Simon
2009-07-09 14:11 ` Chong Yidong
2009-07-09 14:38 ` Marshall, Simon
2009-07-22 12:21 ` Marshall, Simon
2009-07-22 13:58 ` Chong Yidong
2009-07-23 9:22 ` Marshall, Simon
2009-07-23 11:09 ` Kenichi Handa
[not found] ` <63C2A154B1708946B60726AFDBA00AC00668060C@ukmailemea01.misys.global.ad>
[not found] ` <E1MU9G3-0008Hv-HO@etlke! ! ! ! n>
[not found] ` <E1MU9G3-0008Hv-HO@etlke! ! ! ! ! n >
[not found] ` <E1MU9G3-0008Hv-HO@etlke! ! ! n>
[not found] ` <E1MU9G3-0008Hv-HO@etlke! ! n>
2009-07-24 1:07 ` Kenichi Handa
2009-07-24 8:31 ` Marshall, Simon
2009-07-24 11:08 ` Kenichi Handa
2009-07-24 12:09 ` Marshall, Simon
2009-07-24 12:31 ` Kenichi Handa
[not found] ` <63C2A154B1708946B60726AFDBA00AC00676DBAF@ukmailemea01.misys.global.ad>
2009-07-24 15:28 ` Chong Yidong
2009-07-24 16:01 ` Marshall, Simon
2009-07-26 19:35 ` Chong Yidong
2009-07-27 9:48 ` Marshall, Simon
2009-07-27 1:44 ` Kenichi Handa
[not found] ` <63C2A154B1708946B60726AFDBA00AC0067E980A@ukmailemea01.misys.global.ad>
2009-07-27 16:59 ` Chong Yidong
2009-07-27 17:02 ` Chong Yidong
2009-07-28 2:08 ` Kenichi Handa
2009-07-28 8:38 ` Marshall, Simon
2009-06-27 2:48 Chong Yidong
-- strict thread matches above, loose matches on Subject: below --
2009-06-27 3:08 Chong Yidong
2009-06-28 1:04 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ws6y2wle.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=3659@emacsbugs.donarmstrong.com \
--cc=Simon.Marshall@misys.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.