From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#3494: Review line-move-visual patch Date: Sat, 11 Jul 2009 13:17:34 -0400 Message-ID: <87ws6ff8b5.fsf@stupidchicken.com> Reply-To: Chong Yidong , 3494@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1247333904 23419 80.91.229.12 (11 Jul 2009 17:38:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 11 Jul 2009 17:38:24 +0000 (UTC) Cc: 3494@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 11 19:38:16 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MPgWd-0003z6-Fq for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 Jul 2009 19:38:15 +0200 Original-Received: from localhost ([127.0.0.1]:60357 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MPgWc-0005W1-VV for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 Jul 2009 13:38:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MPgW1-0005Gj-4O for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2009 13:37:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MPgVv-0005DU-8G for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2009 13:37:35 -0400 Original-Received: from [199.232.76.173] (port=43684 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MPgVu-0005DD-QN for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2009 13:37:30 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:54681) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MPgVu-0005cA-47 for bug-gnu-emacs@gnu.org; Sat, 11 Jul 2009 13:37:30 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6BHbRpl001359; Sat, 11 Jul 2009 10:37:27 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n6BHP5Hn031779; Sat, 11 Jul 2009 10:25:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Chong Yidong Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 11 Jul 2009 17:25:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3494 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3494-submit@emacsbugs.donarmstrong.com id=B3494.124733266530933 (code B ref 3494); Sat, 11 Jul 2009 17:25:05 +0000 Original-Received: (at 3494) by emacsbugs.donarmstrong.com; 11 Jul 2009 17:17:45 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from pantheon-po30.its.yale.edu (pantheon-po30.its.yale.edu [130.132.50.4]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6BHHfVc030926 for <3494@emacsbugs.donarmstrong.com>; Sat, 11 Jul 2009 10:17:42 -0700 Original-Received: from furry (c-71-192-161-14.hsd1.nh.comcast.net [71.192.161.14]) (authenticated bits=0) by pantheon-po30.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n6BHHZK3012006 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 11 Jul 2009 13:17:35 -0400 Original-Received: by furry (Postfix, from userid 1000) id C5C59C09B; Sat, 11 Jul 2009 13:17:34 -0400 (EDT) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sat, 11 Jul 2009 13:37:35 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:29334 Archived-At: Hi Stefan, I just checked in a patch into the trunk, which makes line-move-visual play properly with truncated lines (Bugs 3494 and 3805). I think it should go to the branch as well. Could you review it? 2009-07-11 Chong Yidong * simple.el (temporary-goal-column): Change the value for line-move-visual to a cons cell. (line-move-visual): Record or set the window hscroll, if necessary (Bug#3494). (line-move-1): Handle cons value of temporary-goal-column.