all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org, Kenichi Handa <handa@m17n.org>
Subject: Re: faster unicode character name completion
Date: Mon, 07 Dec 2009 22:28:44 +0200	[thread overview]
Message-ID: <87ws0yttoj.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwvk4wyj22f.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 07 Dec 2009 09:57:46 -0500")

> But I have a better idea: most of the time is not spent building the
> completion table, but rather just weeding out all the "chars" that don't
> have names, or should I say, looking for the few rare chars that do
> have a name.
>
> So the patch below seems to eb a good compromise: it uses up just about
> 1000K cons cells (i.e. 16KB on 64bit systems) to keep the precomputed
> set of ~34K chars that do have a name, so that building the completion
> table takes only a couple seconds.

Before this change building the completion table took 10s, now only 2s.
The size was 88,203, now 91,595.  I think it's a reasonable price for
such a speedup.

BTW, a related problem: it would be better to hide old obsolete Unicode
names to not advertise them, but still allow completions on them.
For instance, duplicate names such as

  name: LATIN CAPITAL LETTER A WITH ACUTE
  old-name: LATIN CAPITAL LETTER A ACUTE

add too much noise.  Maybe to use the same approach as used for
`completion-ignored-extensions', i.e. to ignore old names, but don't
ignore if all possible completions end in one of them.

-- 
Juri Linkov
http://www.jurta.org/emacs/




  reply	other threads:[~2009-12-07 20:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-30 19:55 Emacs 23.2 pretest freeze? Karl Fogel
2009-11-30 22:48 ` Chong Yidong
2009-11-30 23:05   ` Karl Fogel
2009-12-02 13:34   ` Alan Mackenzie
2009-12-03 21:35 ` Emacs 23.2 Pretest next week Chong Yidong
2009-12-04 11:23   ` faster unicode character name completion Kenichi Handa
2009-12-04 12:08     ` Deniz Dogan
2009-12-04 13:04     ` Juanma Barranquero
2009-12-04 13:26     ` Florian Beck
2009-12-04 15:07     ` Stefan Monnier
2009-12-04 22:38       ` Miles Bader
2009-12-07  2:00       ` Kenichi Handa
2009-12-07  8:13         ` Kenichi Handa
2009-12-07 14:57         ` Stefan Monnier
2009-12-07 20:28           ` Juri Linkov [this message]
2009-12-07 21:42             ` Stefan Monnier
2009-12-08  1:59               ` Miles Bader
2009-12-08  1:45           ` Kenichi Handa
2009-12-08  2:29             ` Stefan Monnier
2009-12-09  0:12             ` Chong Yidong
2009-12-09  0:57               ` Kenichi Handa
2009-12-09  9:02                 ` Deniz Dogan
2009-12-04 19:04   ` Emacs 23.2 Pretest next week Dan Nicolaescu
2009-12-04 21:15     ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ws0yttoj.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    --cc=handa@m17n.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.