From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Engster Newsgroups: gmane.emacs.bugs Subject: bug#5342: 23.1; mairix-widget-search always shows whole threads Date: Sun, 10 Jan 2010 14:51:04 +0100 Message-ID: <87wrzqrruf.fsf@engster.org> References: Reply-To: David Engster , 5342@debbugs.gnu.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1263135071 32498 80.91.229.12 (10 Jan 2010 14:51:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Jan 2010 14:51:11 +0000 (UTC) Cc: 5342@debbugs.gnu.org To: David Abrahams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 10 15:51:03 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NTz8B-0005if-7n for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Jan 2010 15:51:03 +0100 Original-Received: from localhost ([127.0.0.1]:57636 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NTz8C-0006CD-08 for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Jan 2010 09:51:04 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NTz6O-0005DC-I0 for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2010 09:49:12 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NTz6J-00056K-6Y for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2010 09:49:11 -0500 Original-Received: from [199.232.76.173] (port=38879 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NTz6J-00056G-4V for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2010 09:49:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39397) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NTz6I-0000yZ-P2 for bug-gnu-emacs@gnu.org; Sun, 10 Jan 2010 09:49:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NTyqk-0004Fe-RP; Sun, 10 Jan 2010 09:33:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Mail-Followup-To: David Engster , 5342@debbugs.gnu.org Resent-From: David Engster Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jan 2010 14:33:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5342 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5342-submit@debbugs.gnu.org id=B5342.126313396116308 (code B ref 5342); Sun, 10 Jan 2010 14:33:02 +0000 Original-Received: (at 5342) by debbugs.gnu.org; 10 Jan 2010 14:32:41 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NTyqM-0004Ey-Ql for submit@debbugs.gnu.org; Sun, 10 Jan 2010 09:32:39 -0500 Original-Received: from m61s02.vlinux.de ([83.151.21.164]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NTyCG-0003al-73 for 5342@debbugs.gnu.org; Sun, 10 Jan 2010 08:51:13 -0500 Original-Received: from dslc-082-082-163-198.pools.arcor-ip.net ([82.82.163.198] helo=void) by m61s02.vlinux.de with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1NTyC9-0000yq-Q5; Sun, 10 Jan 2010 14:51:06 +0100 In-Reply-To: (David Abrahams's message of "Fri, 08 Jan 2010 13:46:26 -0500") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) X-Spam-Score: -2.6 (--) X-Mailman-Approved-At: Sun, 10 Jan 2010 09:32:38 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -2.6 (--) Resent-Date: Sun, 10 Jan 2010 09:33:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34164 Archived-At: --=-=-= David Abrahams writes: > Please write in English if possible, because the Emacs maintainers > `M-x mairix-widget-search' > search on body containing "foobar" > do NOT check "Show full threads" > finds all messages in threads that mention foobar in the body of any message. > > Tracked it down to > > (defun mairix-widget-send-query (widgets) > "Send query from WIDGETS to mairix binary." > (mairix-search > (mairix-widget-make-query-from-widgets widgets) > (if (widget-value (cadr (assoc "Threads" widgets))) > t > -1)) > ; ^^---------this should be nil > (kill-buffer mairix-customize-query-buffer)) I can confirm this change fixes the bug. Thank you for tracking it down. I attached a bzr bundle containing the above patch. Could please someone commit this as a tiny change by Dave Abrahams and close this bug? Thanks, David --=-=-= Content-Disposition: inline; filename=mairix-el-bug-5342.txt # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: void@void-20100110134124-hfbk3j5r5xns33kr # target_branch: http://bzr.savannah.gnu.org/srv/bzr/emacs/trunk # testament_sha1: 474d00d991bef2c435a2bd6a1eb45039f742af62 # timestamp: 2010-01-10 14:47:44 +0100 # base_revision_id: monnier@iro.umontreal.ca-20100110052254-\ # 6c004mpy2oj0fkey # # Begin patch === modified file 'lisp/net/mairix.el' --- lisp/net/mairix.el 2009-10-31 02:38:34 +0000 +++ lisp/net/mairix.el 2010-01-10 13:41:24 +0000 @@ -597,7 +597,7 @@ (mairix-widget-make-query-from-widgets widgets) (if (widget-value (cadr (assoc "Threads" widgets))) t - -1)) + nil)) (kill-buffer mairix-customize-query-buffer)) (defun mairix-widget-save-search (widgets) # Begin bundle IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWbh+TvsAAXtfgCAQWOP/91MA AAD////wUANF5cS7bHHr1hKIiYaKemk8m0RpNPICGnomjQEokwQxSeNUbJNNNDQAAAGRT0CGqDya mYnpR6g0AAAG1TSmjTQAGhpoABoGg00ElDUNJqaep4U9JtNTT00QyAxA0ZQ8k6V9SmpUqzRuAYyy yCyBjZ0ZVxbLTueoq/Psn1BmF8lBeWzTH47+5l+x0XKnopLR2ovY9sdvAYolnVSq+Xg6n79dTRiZ CUBwomb56I/RtzLIY3g1KhhlK3NoRVXbNT9g9BrTlaEwz0EyBkqh3EcMmFUcqIBWpQeXEw+G7A5q +oWuZBMu9wuqurSY15ToJFFM/itxEv4W1bN9yOEvqnofU9vlOFkguFt1ksXOtQRqTGPMcS0N18Eq BTAFZsJDJsxJ3IwEZu0Sh4nPjvs5WLtiS14A3vBs2YVZSvGgNgM60DqqyoLRLA1OO3Rn1wFxWOKB hQ5NIQNqqa/GRmwoBEQukHfZ1BzNBNkCm6mWjdVKApXOO5LjbOrFiPIuzG3qmivGJIhPNb7ZTOSF 6ykPjQcjCAS12TxydcUWRdHsaSkOct0UdNQWUoHowgA+CQf4C3hvZLh2Jr6LmAhLpIVO2TXK6VgX 7oCHYDyANVnKv+rdztuKLlh0g3whAHdhWrIb3yQjkpv2D1MtRhhlhrg3qEttr+ptC9OcmL4gWjzw 3YzQTTagLLq0+N7hCkTcKROjRJEBcUC5jO1vGZJt5Mdehq4Y7ZLzFksgYXIPxh5kSelzk20rJdtS aTQsvZhFCYIqaMa7gzX4tytM9rgcmSQzX1J5swTWI82JQd9WE7kpabyrFDP6jleFUXQSJs6Ka7Ce bciR+EYB0hIEaTzhcmK7Q6/a6uFgWI/Qz5Br/rkUx4dq4CvMRSp+kGFLqwcdgODMDPBlPIVYS9Lv fk6pR0UFtkAoCR58LbM0oYPqYGofj4B0kDJbxRRAKzDiTZlwJeLI2kB5ohSmjSVVV0oiZi1Bhjc4 ZPk7mZWqmHiaHKxcBODMGMl/WE0ERxpJ8rUUJwT2YOcKpw4hKQjpjHFVoqkngsEunAehqGSVjNhJ YzGTiWnRmGiE4DOWfBZ/zm6/iE96nVYZ96W42jn88mYuF4LCIi+lIMY4E38XckU4UJC4fk77 --=-=-=--