* bug#5342: 23.1; mairix-widget-search always shows whole threads
@ 2010-01-08 18:46 David Abrahams
2010-01-10 13:51 ` David Engster
2010-01-15 16:56 ` Chong Yidong
0 siblings, 2 replies; 3+ messages in thread
From: David Abrahams @ 2010-01-08 18:46 UTC (permalink / raw
To: bug-gnu-emacs, David Engster
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.
Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.
Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:
`M-x mairix-widget-search'
search on body containing "foobar"
do NOT check "Show full threads"
finds all messages in threads that mention foobar in the body of any message.
Tracked it down to
(defun mairix-widget-send-query (widgets)
"Send query from WIDGETS to mairix binary."
(mairix-search
(mairix-widget-make-query-from-widgets widgets)
(if (widget-value (cadr (assoc "Threads" widgets)))
t
-1))
; ^^---------this should be nil
(kill-buffer mairix-customize-query-buffer))
If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
`bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/Applications/Emacs.app/Contents/Resources/etc/DEBUG for instructions.
In GNU Emacs 23.1.1 (i386-apple-darwin9.8.0, NS apple-appkit-949.54)
of 2009-08-16 on black.local
Windowing system distributor `Apple', version 10.3.1038
configured using `configure '--with-ns''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: nil
value of $XMODIFIERS: nil
locale-coding-system: nil
default-enable-multibyte-characters: t
Major mode: Emacs-Lisp
Minor modes in effect:
show-paren-mode: t
server-mode: t
global-auto-revert-mode: t
delete-selection-mode: t
tooltip-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
global-auto-composition-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent input:
C-n C-n C-n C-n C-n C-n C-n C-n <return> <tab> m a
i r i x C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n
C-n C-n C-a C-f <return> C-n C-n C-n C-p C-e C-b C-f
C-x C-e C-n C-n C-b C-p C-p C-p C-p C-p C-n M-x f i
n d - f u n <tab> <return> <return> C-p C-n C-n C-n
C-. C-. C-. C-. C-. C-n C-n C-p C-p C-p C-p C-s t h
r e a d s C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n
C-, C-, C-n C-p C-p C-p C-n C-n C-n C-p C-p C-p M-x
M-p <return> <return> C-n C-n C-n C-n C-n C-p C-p C-p
C-p C-n C-n C-p C-p C-p C-p C-n C-n C-s t h r e a d
s C-x C-b C-x C-b C-p C-p C-p C-p C-p C-p C-p C-p C-p
C-p C-p C-p C-p C-p C-n C-n C-n C-n C-n C-n C-n C-n
C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p C-p C-p
C-p C-p C-p C-p C-p C-p C-p C-p C-n C-n C-n C-n C-n
C-n C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p C-p
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p
C-p C-p C-p C-p C-p C-p C-p C-n C-n C-n C-n C-s - 1
M-< C-n C-n C-n C-n C-n C-n C-p C-p C-p C-e C-n C-e
C-, C-, C-, C-, C-, C-SPC C-e M-w C-n C-n C-n C-n C-n
C-n C-n C-n C-n C-n C-n C-n M-x r e p o r t - e m <tab>
<return>
Recent messages:
Invalid image size (see `max-image-size') [25 times]
Mark set
Invalid image size (see `max-image-size') [97 times]
Mark saved where search started
Invalid image size (see `max-image-size') [50 times]
Mark saved where search started
Mark set
Invalid image size (see `max-image-size')
Mark set
Invalid image size (see `max-image-size') [24 times]
--
Dave Abrahams Meet me at BoostCon: http://www.boostcon.com
BoostPro Computing
http://www.boostpro.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#5342: 23.1; mairix-widget-search always shows whole threads
2010-01-08 18:46 bug#5342: 23.1; mairix-widget-search always shows whole threads David Abrahams
@ 2010-01-10 13:51 ` David Engster
2010-01-15 16:56 ` Chong Yidong
1 sibling, 0 replies; 3+ messages in thread
From: David Engster @ 2010-01-10 13:51 UTC (permalink / raw
To: David Abrahams; +Cc: 5342
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
David Abrahams <dave@boostpro.com> writes:
> Please write in English if possible, because the Emacs maintainers
> `M-x mairix-widget-search'
> search on body containing "foobar"
> do NOT check "Show full threads"
> finds all messages in threads that mention foobar in the body of any message.
>
> Tracked it down to
>
> (defun mairix-widget-send-query (widgets)
> "Send query from WIDGETS to mairix binary."
> (mairix-search
> (mairix-widget-make-query-from-widgets widgets)
> (if (widget-value (cadr (assoc "Threads" widgets)))
> t
> -1))
> ; ^^---------this should be nil
> (kill-buffer mairix-customize-query-buffer))
I can confirm this change fixes the bug. Thank you for tracking it
down.
I attached a bzr bundle containing the above patch. Could please
someone commit this as a tiny change by Dave Abrahams and close this
bug?
Thanks,
David
[-- Attachment #2: mairix-el-bug-5342.txt --]
[-- Type: text/plain, Size: 2004 bytes --]
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: void@void-20100110134124-hfbk3j5r5xns33kr
# target_branch: http://bzr.savannah.gnu.org/srv/bzr/emacs/trunk
# testament_sha1: 474d00d991bef2c435a2bd6a1eb45039f742af62
# timestamp: 2010-01-10 14:47:44 +0100
# base_revision_id: monnier@iro.umontreal.ca-20100110052254-\
# 6c004mpy2oj0fkey
#
# Begin patch
=== modified file 'lisp/net/mairix.el'
--- lisp/net/mairix.el 2009-10-31 02:38:34 +0000
+++ lisp/net/mairix.el 2010-01-10 13:41:24 +0000
@@ -597,7 +597,7 @@
(mairix-widget-make-query-from-widgets widgets)
(if (widget-value (cadr (assoc "Threads" widgets)))
t
- -1))
+ nil))
(kill-buffer mairix-customize-query-buffer))
(defun mairix-widget-save-search (widgets)
# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWbh+TvsAAXtfgCAQWOP/91MA
AAD////wUANF5cS7bHHr1hKIiYaKemk8m0RpNPICGnomjQEokwQxSeNUbJNNNDQAAAGRT0CGqDya
mYnpR6g0AAAG1TSmjTQAGhpoABoGg00ElDUNJqaep4U9JtNTT00QyAxA0ZQ8k6V9SmpUqzRuAYyy
yCyBjZ0ZVxbLTueoq/Psn1BmF8lBeWzTH47+5l+x0XKnopLR2ovY9sdvAYolnVSq+Xg6n79dTRiZ
CUBwomb56I/RtzLIY3g1KhhlK3NoRVXbNT9g9BrTlaEwz0EyBkqh3EcMmFUcqIBWpQeXEw+G7A5q
+oWuZBMu9wuqurSY15ToJFFM/itxEv4W1bN9yOEvqnofU9vlOFkguFt1ksXOtQRqTGPMcS0N18Eq
BTAFZsJDJsxJ3IwEZu0Sh4nPjvs5WLtiS14A3vBs2YVZSvGgNgM60DqqyoLRLA1OO3Rn1wFxWOKB
hQ5NIQNqqa/GRmwoBEQukHfZ1BzNBNkCm6mWjdVKApXOO5LjbOrFiPIuzG3qmivGJIhPNb7ZTOSF
6ykPjQcjCAS12TxydcUWRdHsaSkOct0UdNQWUoHowgA+CQf4C3hvZLh2Jr6LmAhLpIVO2TXK6VgX
7oCHYDyANVnKv+rdztuKLlh0g3whAHdhWrIb3yQjkpv2D1MtRhhlhrg3qEttr+ptC9OcmL4gWjzw
3YzQTTagLLq0+N7hCkTcKROjRJEBcUC5jO1vGZJt5Mdehq4Y7ZLzFksgYXIPxh5kSelzk20rJdtS
aTQsvZhFCYIqaMa7gzX4tytM9rgcmSQzX1J5swTWI82JQd9WE7kpabyrFDP6jleFUXQSJs6Ka7Ce
bciR+EYB0hIEaTzhcmK7Q6/a6uFgWI/Qz5Br/rkUx4dq4CvMRSp+kGFLqwcdgODMDPBlPIVYS9Lv
fk6pR0UFtkAoCR58LbM0oYPqYGofj4B0kDJbxRRAKzDiTZlwJeLI2kB5ohSmjSVVV0oiZi1Bhjc4
ZPk7mZWqmHiaHKxcBODMGMl/WE0ERxpJ8rUUJwT2YOcKpw4hKQjpjHFVoqkngsEunAehqGSVjNhJ
YzGTiWnRmGiE4DOWfBZ/zm6/iE96nVYZ96W42jn88mYuF4LCIi+lIMY4E38XckU4UJC4fk77
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#5342: 23.1; mairix-widget-search always shows whole threads
2010-01-08 18:46 bug#5342: 23.1; mairix-widget-search always shows whole threads David Abrahams
2010-01-10 13:51 ` David Engster
@ 2010-01-15 16:56 ` Chong Yidong
1 sibling, 0 replies; 3+ messages in thread
From: Chong Yidong @ 2010-01-15 16:56 UTC (permalink / raw
To: David Engster; +Cc: David Abrahams, 5342
> I can confirm this change fixes the bug. Thank you for tracking it
> down.
>
> I attached a bzr bundle containing the above patch. Could please
> someone commit this as a tiny change by Dave Abrahams and close this
> bug?
Committed, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-15 16:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-08 18:46 bug#5342: 23.1; mairix-widget-search always shows whole threads David Abrahams
2010-01-10 13:51 ` David Engster
2010-01-15 16:56 ` Chong Yidong
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.