From: David Engster <deng@randomsample.de>
To: David Abrahams <dave@boostpro.com>
Cc: 5342@debbugs.gnu.org
Subject: bug#5342: 23.1; mairix-widget-search always shows whole threads
Date: Sun, 10 Jan 2010 14:51:04 +0100 [thread overview]
Message-ID: <87wrzqrruf.fsf@engster.org> (raw)
In-Reply-To: <m2k4vswi2l.wl%dave@boostpro.com> (David Abrahams's message of "Fri, 08 Jan 2010 13:46:26 -0500")
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
David Abrahams <dave@boostpro.com> writes:
> Please write in English if possible, because the Emacs maintainers
> `M-x mairix-widget-search'
> search on body containing "foobar"
> do NOT check "Show full threads"
> finds all messages in threads that mention foobar in the body of any message.
>
> Tracked it down to
>
> (defun mairix-widget-send-query (widgets)
> "Send query from WIDGETS to mairix binary."
> (mairix-search
> (mairix-widget-make-query-from-widgets widgets)
> (if (widget-value (cadr (assoc "Threads" widgets)))
> t
> -1))
> ; ^^---------this should be nil
> (kill-buffer mairix-customize-query-buffer))
I can confirm this change fixes the bug. Thank you for tracking it
down.
I attached a bzr bundle containing the above patch. Could please
someone commit this as a tiny change by Dave Abrahams and close this
bug?
Thanks,
David
[-- Attachment #2: mairix-el-bug-5342.txt --]
[-- Type: text/plain, Size: 2004 bytes --]
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: void@void-20100110134124-hfbk3j5r5xns33kr
# target_branch: http://bzr.savannah.gnu.org/srv/bzr/emacs/trunk
# testament_sha1: 474d00d991bef2c435a2bd6a1eb45039f742af62
# timestamp: 2010-01-10 14:47:44 +0100
# base_revision_id: monnier@iro.umontreal.ca-20100110052254-\
# 6c004mpy2oj0fkey
#
# Begin patch
=== modified file 'lisp/net/mairix.el'
--- lisp/net/mairix.el 2009-10-31 02:38:34 +0000
+++ lisp/net/mairix.el 2010-01-10 13:41:24 +0000
@@ -597,7 +597,7 @@
(mairix-widget-make-query-from-widgets widgets)
(if (widget-value (cadr (assoc "Threads" widgets)))
t
- -1))
+ nil))
(kill-buffer mairix-customize-query-buffer))
(defun mairix-widget-save-search (widgets)
# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWbh+TvsAAXtfgCAQWOP/91MA
AAD////wUANF5cS7bHHr1hKIiYaKemk8m0RpNPICGnomjQEokwQxSeNUbJNNNDQAAAGRT0CGqDya
mYnpR6g0AAAG1TSmjTQAGhpoABoGg00ElDUNJqaep4U9JtNTT00QyAxA0ZQ8k6V9SmpUqzRuAYyy
yCyBjZ0ZVxbLTueoq/Psn1BmF8lBeWzTH47+5l+x0XKnopLR2ovY9sdvAYolnVSq+Xg6n79dTRiZ
CUBwomb56I/RtzLIY3g1KhhlK3NoRVXbNT9g9BrTlaEwz0EyBkqh3EcMmFUcqIBWpQeXEw+G7A5q
+oWuZBMu9wuqurSY15ToJFFM/itxEv4W1bN9yOEvqnofU9vlOFkguFt1ksXOtQRqTGPMcS0N18Eq
BTAFZsJDJsxJ3IwEZu0Sh4nPjvs5WLtiS14A3vBs2YVZSvGgNgM60DqqyoLRLA1OO3Rn1wFxWOKB
hQ5NIQNqqa/GRmwoBEQukHfZ1BzNBNkCm6mWjdVKApXOO5LjbOrFiPIuzG3qmivGJIhPNb7ZTOSF
6ykPjQcjCAS12TxydcUWRdHsaSkOct0UdNQWUoHowgA+CQf4C3hvZLh2Jr6LmAhLpIVO2TXK6VgX
7oCHYDyANVnKv+rdztuKLlh0g3whAHdhWrIb3yQjkpv2D1MtRhhlhrg3qEttr+ptC9OcmL4gWjzw
3YzQTTagLLq0+N7hCkTcKROjRJEBcUC5jO1vGZJt5Mdehq4Y7ZLzFksgYXIPxh5kSelzk20rJdtS
aTQsvZhFCYIqaMa7gzX4tytM9rgcmSQzX1J5swTWI82JQd9WE7kpabyrFDP6jleFUXQSJs6Ka7Ce
bciR+EYB0hIEaTzhcmK7Q6/a6uFgWI/Qz5Br/rkUx4dq4CvMRSp+kGFLqwcdgODMDPBlPIVYS9Lv
fk6pR0UFtkAoCR58LbM0oYPqYGofj4B0kDJbxRRAKzDiTZlwJeLI2kB5ohSmjSVVV0oiZi1Bhjc4
ZPk7mZWqmHiaHKxcBODMGMl/WE0ERxpJ8rUUJwT2YOcKpw4hKQjpjHFVoqkngsEunAehqGSVjNhJ
YzGTiWnRmGiE4DOWfBZ/zm6/iE96nVYZ96W42jn88mYuF4LCIi+lIMY4E38XckU4UJC4fk77
next prev parent reply other threads:[~2010-01-10 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 18:46 bug#5342: 23.1; mairix-widget-search always shows whole threads David Abrahams
2010-01-10 13:51 ` David Engster [this message]
2010-01-15 16:56 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrzqrruf.fsf@engster.org \
--to=deng@randomsample.de \
--cc=5342@debbugs.gnu.org \
--cc=dave@boostpro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.