* bug#3541: 23.0.94; missing comma in the macro ad-set-orig-definition
@ 2009-06-12 6:09 Dmitri Paduchikh
2010-01-23 23:06 ` Chong Yidong
0 siblings, 1 reply; 2+ messages in thread
From: Dmitri Paduchikh @ 2009-06-12 6:09 UTC (permalink / raw
To: emacs-pretest-bug
Here is a patch which adds the missing comma in the macro
ad-set-orig-definition.
diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el
index fa5d57a..27c65ec 100644
--- a/lisp/emacs-lisp/advice.el
+++ b/lisp/emacs-lisp/advice.el
@@ -2191,7 +2191,7 @@ Redefining advices affect the construction of an advised definition."
(defmacro ad-set-orig-definition (function definition)
`(ad-safe-fset
- (ad-get-advice-info-field function 'origname) ,definition))
+ (ad-get-advice-info-field ,function 'origname) ,definition))
(defmacro ad-clear-orig-definition (function)
`(fmakunbound (ad-get-advice-info-field ,function 'origname)))
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#3541: 23.0.94; missing comma in the macro ad-set-orig-definition
2009-06-12 6:09 bug#3541: 23.0.94; missing comma in the macro ad-set-orig-definition Dmitri Paduchikh
@ 2010-01-23 23:06 ` Chong Yidong
0 siblings, 0 replies; 2+ messages in thread
From: Chong Yidong @ 2010-01-23 23:06 UTC (permalink / raw
To: Dmitri Paduchikh; +Cc: 3541
> (defmacro ad-set-orig-definition (function definition)
> `(ad-safe-fset
> - (ad-get-advice-info-field function 'origname) ,definition))
> + (ad-get-advice-info-field ,function 'origname) ,definition))
>
> (defmacro ad-clear-orig-definition (function)
> `(fmakunbound (ad-get-advice-info-field ,function 'origname)))
Sorry for the delayed response. You're right, this is a mistake. I've
checked your patch into the repository, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-23 23:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-12 6:09 bug#3541: 23.0.94; missing comma in the macro ad-set-orig-definition Dmitri Paduchikh
2010-01-23 23:06 ` Chong Yidong
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.