all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: Stephen Leake <stephen_leake@member.fsf.org>
Cc: emacs-devel@gnu.org, jemarch@gnu.org
Subject: Re: Casing of number literals in ada-mode
Date: Sun, 07 Feb 2010 20:32:01 -0500	[thread overview]
Message-ID: <87wryocy26.fsf@stupidchicken.com> (raw)
In-Reply-To: <871vgwpuph.wl%jemarch@gnu.org> (jemarch@gnu.org's message of "Sun, 07 Feb 2010 23:06:02 +0100")

Hi Stephen, could you check this patch?  If it's OK, we can commit it.
Thanks.


jemarch@gnu.org writes:

> Appended is a little patch that makes ada-mode to not case number
> literals to avoid situations like:
>
>       subtype U32 is range 16#0000_0000#..16#Ffff_Ffff#;
>
> Note the Ffff_Ffff.
>
> 2010-02-06  Jose E. Marchesi  <jemarch@gnu.org>
>
> 	* progmodes/ada-mode.el (ada-in-numeric-literal-p): New function.
> 	(ada-adjust-case): Don't adjust case in hexadecimal number
> 	literals.
>
> === modified file 'lisp/progmodes/ada-mode.el'
> --- lisp/progmodes/ada-mode.el	2010-01-23 12:34:52 +0000
> +++ lisp/progmodes/ada-mode.el	2010-02-07 22:02:29 +0000
> @@ -1009,6 +1009,10 @@
>  	     (parse-partial-sexp
>  	      (line-beginning-position) (point)))))
>  
> +(defsubst ada-in-numeric-literal-p ()
> +  "Return t if point is after a prefix of a numeric literal."
> +  (looking-back "\\([0-9]+#[0-9a-fA-F_]+\\)"))
> +
>  (defsubst ada-in-string-or-comment-p (&optional parse-result)
>    "Return t if inside a comment or string.
>  If PARSE-RESULT is non-nil, use it instead of calling `parse-partial-sexp'."
> @@ -1606,6 +1610,8 @@
>  		 (eq (char-syntax (char-before)) ?w)
>  		 ;;  if in a string or a comment
>  		 (not (ada-in-string-or-comment-p))
> +                 ;;  if in a numeric literal
> +                 (not (ada-in-numeric-literal-p))
>  		 )
>  	    (if (save-excursion
>  		  (forward-word -1)




  reply	other threads:[~2010-02-08  1:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-07 22:06 Casing of number literals in ada-mode jemarch
2010-02-08  1:32 ` Chong Yidong [this message]
2010-02-08 16:37   ` Stephen Leake
2010-02-08 18:30     ` jemarch
2010-02-08 22:13       ` Stephen Leake
2010-02-08 22:28         ` jemarch
2010-02-08 23:27         ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wryocy26.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=jemarch@gnu.org \
    --cc=stephen_leake@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.