From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.bugs Subject: bug#5975: [PATCH] Allow using C-w (bookmark-yank-word) when bookmarking from a gnus article buffer. Date: Wed, 14 Jul 2010 12:44:09 -0400 Message-ID: <87wrsy9fom.fsf@kslab.red-bean.com> References: <87630icytd.fsf@tux.homenetwork> Reply-To: Karl Fogel NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1279126838 21821 80.91.229.12 (14 Jul 2010 17:00:38 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 14 Jul 2010 17:00:38 +0000 (UTC) Cc: 5975-done@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 14 19:00:36 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OZ5Jy-0007cQ-6A for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Jul 2010 19:00:34 +0200 Original-Received: from localhost ([127.0.0.1]:59975 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZ5Jx-0001Y0-Jh for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Jul 2010 13:00:33 -0400 Original-Received: from [140.186.70.92] (port=38429 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZ5Jr-0001X7-Uj for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2010 13:00:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OZ5Jq-0001YK-J1 for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2010 13:00:27 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59301) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZ5Jq-0001YG-EZ for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2010 13:00:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OZ53x-0008Vv-U9 for bug-gnu-emacs@gnu.org; Wed, 14 Jul 2010 12:44:01 -0400 Resent-From: Karl Fogel Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Jul 2010 16:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 5975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 5975@debbugs.gnu.org, kfogel@red-bean.com Original-Received: via spool by 5975-done@debbugs.gnu.org id=D5975.127912584132720 (code D ref 5975); Wed, 14 Jul 2010 16:44:01 +0000 Original-Received: (at 5975-done) by debbugs.gnu.org; 14 Jul 2010 16:44:01 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZ53w-0008Vh-Bc for submit@debbugs.gnu.org; Wed, 14 Jul 2010 12:44:00 -0400 Original-Received: from osh-net-219-98.onshore.net ([66.146.219.98] helo=sanpietro.red-bean.com) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZ53u-0008VY-IY for 5975-done@debbugs.gnu.org; Wed, 14 Jul 2010 12:43:59 -0400 Original-Received: from localhost ([127.0.0.1]:53466 helo=kslab.red-bean.com ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.72) (envelope-from ) id 1OZ542-0006zQ-J1; Wed, 14 Jul 2010 11:44:06 -0500 In-Reply-To: <87630icytd.fsf@tux.homenetwork> (Thierry Volpiatto's message of "Wed, 14 Jul 2010 09:22:38 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 14 Jul 2010 12:44:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38516 Archived-At: I've committed the C-w patch to trunk. I examined it and tested it, and it seems to work fine here. Please check it over to make sure! Below are all the relevant bzr revisions, including the precedents. Best, -Karl ------------------------------------------------------------ revno: 100821 revision-id: kfogel@red-bean.com-20100714164140-v2fdq4b6r45zpxev parent: kfogel@red-bean.com-20100714160253-bbfda9e1g7myj1o8 author: Thierry Volpiatto committer: Karl Fogel branch nick: trunk timestamp: Wed 2010-07-14 12:41:40 -0400 message: Allow C-w when setting a bookmark in a Gnus Article buffer (Bug#5975). * lisp/bookmark.el (bookmark-set): Don't set `bookmark-yank-point' and `bookmark-current-buffer' if they have been already set in another buffer (e.g gnus-art). * lisp/gnus/gnus-sum.el (gnus-summary-bookmark-make-record): Set `bookmark-yank-point' and `bookmark-current-buffer' to allow C-w. ------------------------------------------------------------ revno: 100820 revision-id: kfogel@red-bean.com-20100714160253-bbfda9e1g7myj1o8 parent: kfogel@red-bean.com-20100714155754-n3k71gay91l4vetv committer: Karl Fogel branch nick: trunk timestamp: Wed 2010-07-14 12:02:53 -0400 message: Allow bookmarks to be set from Gnus Article buffers (Bug #5975). Patch applied (with minor tweaks) by Karl Fogel. Note this leaves C-w still not working correctly from Article buffers; Thierry's patch to fix that will be applied after this. * lisp/gnus/gnus-art.el (bookmark-make-record-function): New local variable. * lisp/gnus/gnus-sum.el (gnus-summary-bookmark-make-record): Allow setting from article buffer. (gnus-summary-bookmark-jump): Maybe jump to article buffer. ------------------------------------------------------------ revno: 100819 revision-id: kfogel@red-bean.com-20100714155754-n3k71gay91l4vetv parent: kfogel@red-bean.com-20100714155426-vnlagemntoe30nu6 committer: Karl Fogel branch nick: trunk timestamp: Wed 2010-07-14 11:57:54 -0400 message: Preparation for setting bookmarks in Gnus article buffers (Bug#5975). * lisp/bookmark.el (bookmark-make-record-default): Allow unneeded information to be omitted from the record. Adjust declarations and calls: * lisp/info.el (bookmark-make-record-default): Adjust declaration. (Info-bookmark-make-record): Adjust call. * lisp/woman.el (bookmark-make-record-default): Adjust declaration. (woman-bookmark-make-record): Adjust call. * lisp/man.el (bookmark-make-record-default): Adjust declaration. (Man-bookmark-make-record): Adjust call. * lisp/image-mode.el (bookmark-make-record-default): Adjust declaration. * lisp/doc-view.el (bookmark-make-record-default): Adjust declaration. * lisp/gnus/gnus-sum.el (bookmark-make-record-default): Adjust declaration.