all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 5364-done@debbugs.gnu.org, jidanni@jidanni.org
Subject: bug#5364: 23.1.91; execute-extended-command should do like FFAP
Date: Mon, 23 Aug 2010 00:32:29 +0100	[thread overview]
Message-ID: <87wrriw7ea.fsf@mail.jurta.org> (raw)
In-Reply-To: <87wrzki0zy.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 15 Jan 2010 03:12:05 +0200")

> This patch moves interactive spec into Elisp and also implements
> the following task from comments in execute-extended-command:
>
>   /* This isn't strictly correct if execute-extended-command
>      is bound to anything else.  Perhaps it should use
>      this_command_keys?  */
>
> It uses `(key-description (this-single-command-keys))' to do this.

Actually, it occured to me that displaying a key other than "M-x"
in the prompt of `execute-extended-command' is too confusing.

For instance, in bindings.el `execute-extended-command' is bound to the
[menu] key.  When I accidentally type the <menu> key, the first reaction
is "What does this mean?!" because it's very strange to see the prompt
"<menu> " waiting for a command.  It looks like a beginning of a key
sequence for the main menu.  OTOH, a well-known prompt "M-x" means
it reads an extended command.  I've added a comment that explains
why "M-x" is better than anything else.

Also we should keep the current function signature of
`execute-extended-command' unchanged and not to add a new arg
for two reasons:

1. There are places in code that call `execute-extended-command'
with one argument.

2. Calling `read-extended-command' to read a command name should not be
in the `interactive' spec because it needs to remember the hourglass
status before reading a command name (using `hourglass_started'),
and restore the hourglass (using `start_hourglass') after that.

So I installed a patch that calls `read-extended-command'
in the middle of `execute-extended-command'.

Of course, moving the whole of `execute-extended-command' to Elisp
would be better but the main obstacle is the hourglass functions
that have no Elisp interface.





  parent reply	other threads:[~2010-08-22 23:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-12 12:52 bug#5364: 23.1.91; execute-extended-command should do like FFAP jidanni
2010-01-12 20:54 ` Juri Linkov
2010-01-12 22:46   ` jidanni
2010-01-13  0:32     ` Juri Linkov
2010-01-13  1:17       ` jidanni
2010-01-13  1:21     ` Stefan Monnier
2010-01-13  2:00       ` jidanni
2010-01-13  4:12         ` Stefan Monnier
2010-01-14  3:33           ` jidanni
2010-01-14 15:12             ` Stefan Monnier
2010-01-14 21:07               ` Juri Linkov
2010-01-14 22:40                 ` Stefan Monnier
2010-01-15  1:12                   ` Juri Linkov
2010-01-15  2:20                     ` Stefan Monnier
2010-01-15  3:06                       ` Chong Yidong
2010-01-15  7:49                         ` Stefan Monnier
2010-01-15  9:19                       ` Juri Linkov
2010-08-22 23:32                     ` Juri Linkov [this message]
2010-01-13  7:26   ` Jan D.
2010-01-14  5:29     ` jidanni
2010-01-14 21:01       ` Juri Linkov
2010-01-15  3:04 ` jidanni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wrriw7ea.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=5364-done@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.