From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Emacs-diffs Digest, Vol 94, Issue 89 Date: Fri, 24 Sep 2010 18:08:35 -0400 Message-ID: <87wrqakd5o.fsf@stupidchicken.com> References: <83zkv7rmpe.fsf@gnu.org> <83tylesyyk.fsf@gnu.org> <83r5gisxmp.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1285366134 30815 80.91.229.12 (24 Sep 2010 22:08:54 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 24 Sep 2010 22:08:54 +0000 (UTC) Cc: larsi@gnus.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 25 00:08:52 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OzGRo-0004fS-AQ for ged-emacs-devel@m.gmane.org; Sat, 25 Sep 2010 00:08:52 +0200 Original-Received: from localhost ([127.0.0.1]:33453 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzGRn-0000cW-Pt for ged-emacs-devel@m.gmane.org; Fri, 24 Sep 2010 18:08:51 -0400 Original-Received: from [140.186.70.92] (port=39050 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzGRa-0000Z5-Pd for emacs-devel@gnu.org; Fri, 24 Sep 2010 18:08:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OzGRZ-0006K4-K8 for emacs-devel@gnu.org; Fri, 24 Sep 2010 18:08:38 -0400 Original-Received: from pantheon-po24.its.yale.edu ([130.132.50.118]:41784) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OzGRZ-0006Js-I1; Fri, 24 Sep 2010 18:08:37 -0400 Original-Received: from furry (dhcp128036014154.central.yale.edu [128.36.14.154]) (authenticated bits=0) by pantheon-po24.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o8OM8awP008481 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 24 Sep 2010 18:08:36 -0400 Original-Received: by furry (Postfix, from userid 1000) id 0B0AA16D402; Fri, 24 Sep 2010 18:08:35 -0400 (EDT) In-Reply-To: <83r5gisxmp.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 24 Sep 2010 22:19:10 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130810 Archived-At: Eli Zaretskii writes: >> - int frame_lines = FRAME_LINES (frame); >> + EMACS_INT frame_lines = FRAME_LINES (frame); > > I think down that lane lies madness, because we have lots of struct > members that are Lisp integers, and assigning the result of XINT of > every one of them to an EMACS_INT will significantly and unnecessarily > increase our stack usage (on 64-bit machines). I think text_lines and related members of `struct frame' should be ints. Dunno why they were made EMACS_INT, though it happened long ago, before Emacs-21. I doubt there is much practical difference, only a conceptual one; IMO the "EMACS_INT" cast is a nice way to denote that an integer may have to do with buffer and string sizes. I don't feel strongly about it, though.