From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: bug in copy-directory Date: Wed, 09 Feb 2011 11:50:17 -0500 Message-ID: <87wrl9rw3a.fsf@stupidchicken.com> References: <87ipxaidea.fsf@gmail.com> <87sjway8i3.fsf@gmx.de> <87wrll2ebe.fsf@stupidchicken.com> <87hbcot7gq.fsf@gmx.de> <87ei7qrdp0.fsf@gmail.com> <87ipx2dayh.fsf@gmx.de> <87y65yyxfu.fsf@gmail.com> <87d3n8xkeq.fsf@gmail.com> <878vxw6r4m.fsf@gmx.de> <87pqr790b0.fsf@gmail.com> <87oc6r7gjc.fsf@gmx.de> <87ipwz8t92.fsf@gmail.com> <878vxt69k7.fsf@stupidchicken.com> <874o8hbc9q.fsf@gmx.de> <87tygh8ez6.fsf@stupidchicken.com> <87zkq7okvk.fsf@gmx.de> <87oc6myqzn.fsf@stupidchicken.com> <87sjvxznmt.fsf@gmail.com> <87aai58v63.fsf@gmx.de> <877hd99q32.fsf@stupidchicken.com> <87aai5gpd1.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297271210 22214 80.91.229.12 (9 Feb 2011 17:06:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 9 Feb 2011 17:06:50 +0000 (UTC) Cc: Michael Albinus , emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 09 18:06:45 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PnDV5-000839-FO for ged-emacs-devel@m.gmane.org; Wed, 09 Feb 2011 18:06:44 +0100 Original-Received: from localhost ([127.0.0.1]:33092 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PnDV2-0001tN-BN for ged-emacs-devel@m.gmane.org; Wed, 09 Feb 2011 12:06:40 -0500 Original-Received: from [140.186.70.92] (port=43758 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PnDFJ-0004Pj-Ev for emacs-devel@gnu.org; Wed, 09 Feb 2011 11:50:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PnDFG-0001dt-KE for emacs-devel@gnu.org; Wed, 09 Feb 2011 11:50:25 -0500 Original-Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]:42214) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PnDFG-0001dh-Hh for emacs-devel@gnu.org; Wed, 09 Feb 2011 11:50:22 -0500 Original-Received: from furball (dhcp128036014105.central.yale.edu [128.36.14.105]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p19GoIIA030622 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 9 Feb 2011 11:50:18 -0500 Original-Received: by furball (Postfix, from userid 1000) id DFD211605C6; Wed, 9 Feb 2011 11:50:17 -0500 (EST) In-Reply-To: <87aai5gpd1.fsf@gmail.com> (Thierry Volpiatto's message of "Wed, 09 Feb 2011 17:11:06 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 130.132.50.146 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135807 Archived-At: Thierry Volpiatto writes: >> Adding a separate copy-directory-1 function does nothing different from >> adding an optional argument to copy-directory that modifies its >> behavior. Not much point. > > I am actually trying something different, i sent patch to Michael and > Stephane. > I restart from the Chong version without extra arg. > This version works outside of dired interactvely and not. > > Then i modify a little dired-create-files. > dired-copy-file-recursive have to call now copy-directory as > copy-directory-1 doesn't exists anymore. > > It works here in dired, all scenarios of copy-directory and i tried with > sudo method from dired and it works also. Such an invasive patch is not suitable for the emacs-23 branch. If we do this, it should be for Emacs 24.