all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Markert <markert.michael@googlemail.com>
To: emacs-devel@gnu.org
Subject: [Patch] lisp/help.el (where-is): Don't overwrite `standard-output'
Date: Mon, 12 Sep 2011 23:19:40 +0200	[thread overview]
Message-ID: <87wrddlaqb.fsf@googlemail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 299 bytes --]


Hi,

I tried to use `where-is' programmatically to avoid doing the parsing
myself but failed because `where-is' resets `standard-output' to `t'.

The appended patch keeps `standard-output' unless told otherwise and
thus enabled getting the output via `with-output-to-string' and the
like.

Michael

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: where-is-honor-standard-output.patch --]
[-- Type: text/x-patch, Size: 518 bytes --]

diff -Naur a/help.el b/help.el
--- a/help.el	2011-09-12 23:04:47.336591539 +0200
+++ b/help.el	2011-09-12 23:05:51.748593189 +0200
@@ -527,7 +527,7 @@
   (unless definition (error "No command"))
   (let ((func (indirect-function definition))
         (defs nil)
-        (standard-output (if insert (current-buffer) t)))
+        (standard-output (if insert (current-buffer) standard-output)))
     ;; In DEFS, find all symbols that are aliases for DEFINITION.
     (mapatoms (lambda (symbol)
 		(and (fboundp symbol)

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

             reply	other threads:[~2011-09-12 21:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-12 21:19 Michael Markert [this message]
2011-09-12 23:01 ` [Patch] lisp/help.el (where-is): Don't overwrite `standard-output' Glenn Morris
2011-09-13  9:36   ` Michael Markert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wrddlaqb.fsf@googlemail.com \
    --to=markert.michael@googlemail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.