From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Julien Danjou Newsgroups: gmane.emacs.bugs Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Date: Sat, 24 Sep 2011 16:19:41 +0200 Message-ID: <87wrcydnuq.fsf@keller.adm.naquadah.org> References: <87pqisi3lu.fsf@keller.adm.naquadah.org> <87ehz7e0ck.fsf@gmx.de> <871uv7i6gb.fsf@keller.adm.naquadah.org> <87bouab1mi.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: dough.gmane.org 1316874038 4356 80.91.229.12 (24 Sep 2011 14:20:38 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 24 Sep 2011 14:20:38 +0000 (UTC) Cc: 9581@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 24 16:20:34 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R7T5m-0005mc-E1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Sep 2011 16:20:34 +0200 Original-Received: from localhost ([::1]:54029 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7T5l-00013U-Gr for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Sep 2011 10:20:33 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:57905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7T5i-00013K-P7 for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2011 10:20:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R7T5h-0004ks-RB for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2011 10:20:30 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7T5h-0004ko-PY for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2011 10:20:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R7T6D-00007z-L3 for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2011 10:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Julien Danjou Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Sep 2011 14:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9581-submit@debbugs.gnu.org id=B9581.1316874018437 (code B ref 9581); Sat, 24 Sep 2011 14:21:01 +0000 Original-Received: (at 9581) by debbugs.gnu.org; 24 Sep 2011 14:20:18 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7T5W-000070-8T for submit@debbugs.gnu.org; Sat, 24 Sep 2011 10:20:18 -0400 Original-Received: from prometheus.naquadah.org ([212.85.154.174] helo=mx1.naquadah.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R7T5T-00006q-QK for 9581@debbugs.gnu.org; Sat, 24 Sep 2011 10:20:17 -0400 Original-Received: from keller.adm.naquadah.org (AMontsouris-651-1-106-83.w83-202.abo.wanadoo.fr [83.202.161.83]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id 47A405C174; Sat, 24 Sep 2011 16:19:42 +0200 (CEST) In-Reply-To: <87bouab1mi.fsf@gmx.de> (Michael Albinus's message of "Sat, 24 Sep 2011 13:50:29 +0200") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 24 Sep 2011 10:21:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51782 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Sep 24 2011, Michael Albinus wrote: > I've committed a fix for both problems, could you, please, check? The patch is not enough. It fixes the precise case I reported, but this fails now: (setq db (dbus-register-signal :session "some.service" "/org/gtk/Private/RemoteVolumeMonitor" "org.gtk.Private.RemoteVolumeMonitor" "VolumeAd= ded" 'identity)) (dbus-unregister-object db) Debugger entered--Lisp error: (dbus-error "Match rule has a key with no sub= sequent '=3D' character") dbus-call-method(:session "org.freedesktop.DBus" "/org/freedesktop/DBus" = "org.freedesktop.DBus" "RemoveMatch" "Z") dbus-unregister-object(((:session "org.gtk.Private.RemoteVolumeMonitor" "= VolumeAdded") ("some.service" "/org/gtk/Private/RemoteVolumeMonitor" identi= ty))) eval((dbus-unregister-object db) nil) And, I've not tested, but AFAICS you added a check "(when service =E2=80=A6" before running ReleaseName. Just not that you must not do a ReleaseName if you are unregistering a match, and I've the feeling that this code will do. > Reading the code, `dbus-registered-objects-table' has become an > unreadable format. Maybe we shall redesign the format, and move most of > the functionality from dbusbind.c to dbus.el. But that's something for > after-the-release. I totally agree with that. It needs to be reworked. :) =2D-=20 Julien Danjou --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJOfeb9AAoJEGEbqVCLeKXCr9YP/17XOZU9R2xeibw/bhK+LnQf cCoMmE3XAmGK3y6pcELUlU8ijTw79jhyyZj3aIWJxw4ZSc4Qlg02WCtoPmNgxZp6 NFu9hTe8xMa1bVJxco7HI32sqHGEktbsAKw7A16h3NV9AG1xXAP96neLdP1AqAWy vu3VGkWIlR4uMVPkz6cr9xayWwM9LxziZwl4oL0SY1yaH/+4RKGxWtD2FqMpTMog 6+1rmB5pigzbJHdYLXwsi0mxAEJiCSIZgPNWf2YGHEEhLdA5zdr5KJ22GN91yciK srLorVPOVBP91Kr3XdFLCLbYbzDitK5xM1sw88cJuIvht1s08tDlclseQ/8nlZ5M Rz0UT95yqLwPMhv1lCz7BRX71PgxjN/RgUyaE4oGFd/Xab1Cz2kHtsP9WjUCnmEy 539+9Z2+C+fC5VZibLfdX/I4Tt+FtQOTDoJWu7pmU2Ovx/M5RKpb08ONtPXFhJUR 93EQb4ITDjOqmXO32rJWBNHGRaFhrq2v96CypoWRyaTkvKWgxp1cXDZ/ScjVQAl3 /5DqDl+piBWxeVlU3/R3X3pNSeoMbUTElwhcZvf6NS88WnC+dMefyNeMpI/i6ri/ phacB9Il9HHVZ9zyShP+tevtfIyM8r+Y54eNODh5jwZeCQ4onGhZML7GDAwh2ey7 unoqwRn/J3d0yI6uHhx6 =RGpa -----END PGP SIGNATURE----- --=-=-=--