From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: xterm.c (x_clear_frame) - commented out call to XClearWindow Date: Tue, 22 Nov 2011 13:31:16 +0800 Message-ID: <87wras4taz.fsf@gnu.org> References: <87k46uukcl.fsf@gnu.org> <87d3cldffb.fsf@gnu.org> <391CC3E1-BEF3-4561-8902-8BEE63CDEAE7@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1321939895 10229 80.91.229.12 (22 Nov 2011 05:31:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 22 Nov 2011 05:31:35 +0000 (UTC) Cc: Geoff Gole , Emacs development discussions To: Jan =?utf-8?Q?Dj=C3=A4rv?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 22 06:31:32 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RSix9-00004y-G6 for ged-emacs-devel@m.gmane.org; Tue, 22 Nov 2011 06:31:31 +0100 Original-Received: from localhost ([::1]:51890 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSix9-00045I-2X for ged-emacs-devel@m.gmane.org; Tue, 22 Nov 2011 00:31:31 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:55997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSix6-00045B-GJ for emacs-devel@gnu.org; Tue, 22 Nov 2011 00:31:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSix4-0004Yk-Px for emacs-devel@gnu.org; Tue, 22 Nov 2011 00:31:28 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:53239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSix4-0004Yg-OX for emacs-devel@gnu.org; Tue, 22 Nov 2011 00:31:26 -0500 Original-Received: from [155.69.16.255] (port=51158 helo=furball) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1RSix3-0006CM-77; Tue, 22 Nov 2011 00:31:25 -0500 In-Reply-To: <391CC3E1-BEF3-4561-8902-8BEE63CDEAE7@swipnet.se> ("Jan \=\?utf-8\?Q\?Dj\=C3\=A4rv\=22's\?\= message of "Mon, 21 Nov 2011 19:02:47 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146129 Archived-At: Jan Dj=C3=A4rv writes: > The uncommented XClearWindow in x_clear_frame must be there so I > activated it again... Flickering is almost unavoidable for Gtk as we > bypass the normal Gtk drawing stuff. Obviously, I disagree. AFAICT this has nothing to do with GTK. The XClearWindow is obviously unnecessary if Emacs covers the entire frame area when drawing glyph strings during redisplay, since the glyph strings apply the background color. The problem here arises because there are some areas of the frame not drawn over durig redisplay, e.g. the leftover spaces to the bottom and right in fullscreen mode. The fact that these areas are unpainted may be regarded as a bug. A suitable temporary work-around would be to paint over them---but painting the entire frame is clearly an overreach. > Just doing > (set-background-color "green") > > and then > > (set-background-color "white") > > leaves big chunks of green where there is no text unless x_clear_frame > does its job. I can't reproduce this at all.