[PATCH] windmove.el: Fix windmove-reference-loc miscalculation

[PATCH] windmove.el: Fix windmove-reference-loc miscalculation

[Jérémy Compostella]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

All,

When using window hscroll (toggle-truncate-lines on a long lines
buffer), windmove misbehaves. I mean : with the following window
configuration :

+------+-----+
|      |     |
|      |  2  |
|  1   +-----+
|      |     |
|      |  3  |
+------+-----+

and with the very long lines buffer as current buffer of window 3 and point
to the end of a line, `windmove-up' selects the window 1 instead of the
window 2.

Please merge the attached patch or review it.

Best regards,

Jérémy

--
Sent from my Emacs


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: [PATCH] windmove.el: Fix windmove-reference-loc miscalculation --]
[-- Type: text/x-diff, Size: 1229 bytes --]

From 65341a5b715062679a228c23f74273194334f417 Mon Sep 17 00:00:00 2001
From: Jeremy Compostella <jeremy.compostella@gmail.com>
Date: Thu, 19 Jan 2012 22:46:17 +0100
Subject: [PATCH] windmove.el: Fix windmove-reference-loc miscalculation

The `windmove-reference-loc' function should not take into account the
`window-hscoll'.

Signed-off-by: Jeremy Compostella <jeremy.compostella@gmail.com>
---
 lisp/windmove.el |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/lisp/windmove.el b/lisp/windmove.el
index 10a5644..424b3e1 100644
--- a/lisp/windmove.el
+++ b/lisp/windmove.el
@@ -422,12 +422,8 @@ supplied, if ARG is greater or smaller than zero, respectively."
           bottom-right)
        ((= effective-arg 0)
           (windmove-coord-add
-             top-left
-	     (let ((col-row
-		    (posn-col-row
-		     (posn-at-point (window-point window) window))))
-	       (cons (- (car col-row) (window-hscroll window))
-		     (cdr col-row)))))))))
+ 	     top-left
+	    (posn-col-row (posn-at-point (window-point window) window))))))))
 
 ;; This uses the reference location in the current window (calculated
 ;; by `windmove-reference-loc' above) to find a reference location
-- 
1.7.2.5

Re: [PATCH] windmove.el: Fix windmove-reference-loc miscalculation

[martin rudalics]

 > When using window hscroll (toggle-truncate-lines on a long lines
 > buffer), windmove misbehaves. I mean : with the following window
 > configuration :
 >
 > +------+-----+
 > |      |     |
 > |      |  2  |
 > |  1   +-----+
 > |      |     |
 > |      |  3  |
 > +------+-----+
 >
 > and with the very long lines buffer as current buffer of window 3 and point
 > to the end of a line, `windmove-up' selects the window 1 instead of the
 > window 2.

Could you kindly provide a simple scenario to reproduce this.  Also
could you please check whether `window-in-direction' suffers from the
same problem?

Thanks, martin

Re: [PATCH] windmove.el: Fix windmove-reference-loc miscalculation

[Sylvain Rousseau]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

For example:

emacs -Q --eval "(progn (toggle-truncate-lines 1) \
(split-window-right) \
(other-window 1) \
(split-window-below) \
(insert
\"blahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblah\"))"

Then try to windmove-down, it moves left! :/

window-in-direction seems to be doing fine anyway!

Sylvain.

[-- Attachment #2: Type: text/html, Size: 438 bytes --]

Re: [PATCH] windmove.el: Fix windmove-reference-loc miscalculation

[Jérémy Compostella]

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

Sylvain, thanks saving my time :)

Effectively the issue is only windmove.el related.

2012/1/20 Sylvain Rousseau <thisirs@gmail.com>

> For example:
>
> emacs -Q --eval "(progn (toggle-truncate-lines 1) \
> (split-window-right) \
> (other-window 1) \
> (split-window-below) \
> (insert
> \"blahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblah\"))"
>
> Then try to windmove-down, it moves left! :/
>
> window-in-direction seems to be doing fine anyway!
>
> Sylvain.
>



-- 
« Si debugger, c'est supprimer des bugs, alors programmer ne peut être que
les ajouter » - Edsger Dijkstra

[-- Attachment #2: Type: text/html, Size: 1044 bytes --]

Re: [PATCH] windmove.el: Fix windmove-reference-loc miscalculation

[martin rudalics]

 > Effectively the issue is only windmove.el related.

So IIUC the issue is that `windmove-reference-loc'

           (windmove-coord-add
              top-left
	     (let ((col-row
		    (posn-col-row
		     (posn-at-point (window-point window) window))))
	       (cons (- (car col-row) (window-hscroll window))
		     (cdr col-row)))))))))

wrongly subtracts the value returned by `window-hscroll' from a column
value correctly calculated by `posn-at-point' (window_box_left_offset)?

In this case I think your patch is correct.

martin

Re: [PATCH] windmove.el: Fix windmove-reference-loc miscalculation

[Jérémy Compostella]

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

2012/1/20 martin rudalics <rudalics@gmx.at>

> > Effectively the issue is only windmove.el related.
>
> So IIUC the issue is that `windmove-reference-loc'
>
>          (windmove-coord-add
>             top-left
>             (let ((col-row
>                    (posn-col-row
>                     (posn-at-point (window-point window) window))))
>               (cons (- (car col-row) (window-hscroll window))
>                     (cdr col-row)))))))))
>
> wrongly subtracts the value returned by `window-hscroll' from a column
> value correctly calculated by `posn-at-point' (window_box_left_offset)?
>
> Yes, you're perfectly right that's my point and my patch remove this.
Thanks.

It's time to friday beer evening now :)

[-- Attachment #2: Type: text/html, Size: 1092 bytes --]

Re: [PATCH] windmove.el: Fix windmove-reference-loc miscalculation

[Jérémy Compostella]

[-- Attachment #1: Type: text/plain, Size: 994 bytes --]

As we agreed about the solution, could you please merge this patch ?
This bug is really annoying to me and probably to many others.

Thanks.

Jérémy

2012/1/20 Jérémy Compostella <jeremy.compostella@gmail.com>

> 2012/1/20 martin rudalics <rudalics@gmx.at>
>
>> > Effectively the issue is only windmove.el related.
>>
>> So IIUC the issue is that `windmove-reference-loc'
>>
>>          (windmove-coord-add
>>             top-left
>>             (let ((col-row
>>                    (posn-col-row
>>                     (posn-at-point (window-point window) window))))
>>               (cons (- (car col-row) (window-hscroll window))
>>                     (cdr col-row)))))))))
>>
>> wrongly subtracts the value returned by `window-hscroll' from a column
>> value correctly calculated by `posn-at-point' (window_box_left_offset)?
>>
>> Yes, you're perfectly right that's my point and my patch remove this.
> Thanks.
>
>  It's time to friday beer evening now :)
>

[-- Attachment #2: Type: text/html, Size: 1652 bytes --]

Re: [PATCH] windmove.el: Fix windmove-reference-loc miscalculation

[martin rudalics]

> As we agreed about the solution, could you please merge this patch ?
> This bug is really annoying to me and probably to many others.

I've installed your patch already ;-)

Next time please make a bug report so it will be easier to provide a
suitable reference to the thread from a comment.

Thanks, martin

Re: [PATCH] windmove.el: Fix windmove-reference-loc miscalculation

[martin rudalics]

> emacs -Q --eval "(progn (toggle-truncate-lines 1) \
> (split-window-right) \
> (other-window 1) \
> (split-window-below) \
> (insert
> \"blahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblahblah\"))"
> 
> Then try to windmove-down, it moves left! :/

Thanks.  I can see it now.

martin