From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 01/10] move some globals into a thread object Date: Mon, 13 Aug 2012 08:19:27 -0600 Message-ID: <87wr127u34.fsf@fleche.redhat.com> References: <87vcgreu1s.fsf@fleche.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1344867596 7844 80.91.229.3 (13 Aug 2012 14:19:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 13 Aug 2012 14:19:56 +0000 (UTC) Cc: Emacs discussions To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 13 16:19:56 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T0vUq-0007rs-E1 for ged-emacs-devel@m.gmane.org; Mon, 13 Aug 2012 16:19:56 +0200 Original-Received: from localhost ([::1]:46279 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0vUp-0004R3-Dc for ged-emacs-devel@m.gmane.org; Mon, 13 Aug 2012 10:19:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0vUY-0003Yo-2e for emacs-devel@gnu.org; Mon, 13 Aug 2012 10:19:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0vUQ-0006SE-CH for emacs-devel@gnu.org; Mon, 13 Aug 2012 10:19:37 -0400 Original-Received: from mx1.redhat.com ([209.132.183.28]:44430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0vUQ-0006Ru-4L for emacs-devel@gnu.org; Mon, 13 Aug 2012 10:19:30 -0400 Original-Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7DEJSxD013116 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 13 Aug 2012 10:19:28 -0400 Original-Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7DEJR3A013678 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 13 Aug 2012 10:19:27 -0400 X-Attribution: Tom In-Reply-To: (Stefan Monnier's message of "Thu, 09 Aug 2012 21:18:58 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152483 Archived-At: >>>>> "Stefan" == Stefan Monnier writes: Tom> The #defines mean that this patch also has to rename a few fields Tom> whose names clash with the defines. Stefan> I'd rather rename the globals (although I understand it will probably Stefan> result in a larger patch), because I'd rather limit the impact of those Stefan> #defines. Ok, I will do this, but please don't let this block looking at the other patches. This particular patch is one of the least interesting ones of the series. The big reason not to do this is just that reindenting everything is tedious. There are thousands of spots to check for line wrapping :-( Just thinking about it makes me want to take a different approach instead. Stefan> If you ever create a local variable (or a struct field) named Stefan> `current_buffer' somewhere, it might take you a good while to Stefan> figure out why your code is misbehaving. FWIW, newish versions of gcc give much better error messages for problems arising from macro expansion. Tom