From: Tom Tromey <tromey@redhat.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs discussions <emacs-devel@gnu.org>
Subject: Re: [PATCH 01/10] move some globals into a thread object
Date: Mon, 13 Aug 2012 08:19:27 -0600 [thread overview]
Message-ID: <87wr127u34.fsf@fleche.redhat.com> (raw)
In-Reply-To: <jwvd32z7dh0.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 09 Aug 2012 21:18:58 -0400")
>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:
Tom> The #defines mean that this patch also has to rename a few fields
Tom> whose names clash with the defines.
Stefan> I'd rather rename the globals (although I understand it will probably
Stefan> result in a larger patch), because I'd rather limit the impact of those
Stefan> #defines.
Ok, I will do this, but please don't let this block looking at the other
patches. This particular patch is one of the least interesting ones of
the series.
The big reason not to do this is just that reindenting everything is
tedious. There are thousands of spots to check for line wrapping :-(
Just thinking about it makes me want to take a different approach instead.
Stefan> If you ever create a local variable (or a struct field) named
Stefan> `current_buffer' somewhere, it might take you a good while to
Stefan> figure out why your code is misbehaving.
FWIW, newish versions of gcc give much better error messages for
problems arising from macro expansion.
Tom
prev parent reply other threads:[~2012-08-13 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 19:37 [PATCH 01/10] move some globals into a thread object Tom Tromey
2012-08-10 1:18 ` Stefan Monnier
2012-08-13 14:19 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wr127u34.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.