From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christopher Schmidt Newsgroups: gmane.emacs.bugs Subject: bug#12288: 24.2.50; compilation-start: Query for killing existing compilation process only if query-on-exit-flag is non-nil Date: Sun, 2 Sep 2012 02:21:40 +0100 (BST) Message-ID: <87wr0d2p99@ch.ristopher.com> References: <87ehms759q@ch.ristopher.com> <874nnit3f9@ch.ristopher.com> <1346512261.21458.140661122378029.2F7185E7@webmail.messagingengine.com> <87y5kt92yp@ch.ristopher.com> <1346523470.14751.140661122426041.16CA21FC@webmail.messagingengine.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1346548965 17807 80.91.229.3 (2 Sep 2012 01:22:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 2 Sep 2012 01:22:45 +0000 (UTC) Cc: 12288@debbugs.gnu.org To: Martin Blais Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 02 03:22:46 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T7yti-0001rK-67 for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Sep 2012 03:22:46 +0200 Original-Received: from localhost ([::1]:37409 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7ytf-0003GN-Cz for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Sep 2012 21:22:43 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7ytb-0003Fu-TU for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2012 21:22:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7yta-0008N7-Q8 for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2012 21:22:39 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7yta-0008N3-Na for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2012 21:22:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T7yuw-0006lL-Cv for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2012 21:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Christopher Schmidt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Sep 2012 01:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12288 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.134654899425931 (code B ref -1); Sun, 02 Sep 2012 01:24:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Sep 2012 01:23:14 +0000 Original-Received: from localhost ([127.0.0.1]:33462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T7yuA-0006kB-CJ for submit@debbugs.gnu.org; Sat, 01 Sep 2012 21:23:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52145) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T7yu7-0006k3-55 for submit@debbugs.gnu.org; Sat, 01 Sep 2012 21:23:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7ysj-000883-R3 for submit@debbugs.gnu.org; Sat, 01 Sep 2012 21:21:47 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:46983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7ysj-00087z-OL for submit@debbugs.gnu.org; Sat, 01 Sep 2012 21:21:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7ysi-0003DK-Qe for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2012 21:21:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7ysh-00087f-Ky for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2012 21:21:44 -0400 Original-Received: from ristopher.com ([146.185.21.93]:54048 helo=saturn.ch.ristopher.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7ysh-00087X-CP for bug-gnu-emacs@gnu.org; Sat, 01 Sep 2012 21:21:43 -0400 Original-Received: by saturn.ch.ristopher.com (Postfix, from userid 0) id 9C1AE20D26; Sun, 2 Sep 2012 02:21:40 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ch.ristopher.com; s=mail; t=1346548900; bh=h1XvLKCVE10CNkiYvZwxi+uuDR/Wa5aZlYeRXNQQO6g=; h=From:To:Cc:Subject:In-Reply-To:References:Message-ID:MIME-Version: Content-Type:Date; b=GoRN1qYBnXRK8b1otYB6R1xva4HfON03rhmuY8h3Y8v1Gc1//TCR+FQgw4EgdpEkQ aA2ze1bR7FQ60z+aHiHaVuD2IeYYdjO1pmQO2HiCrMNJ7Rn4J68m6oryYx37Aykiw2 3sa7W2vBng33bOGlv9Gv9G1/+qjCk4sJA3yrgsLQ= In-Reply-To: <1346523470.14751.140661122426041.16CA21FC@webmail.messagingengine.com> (Martin Blais's message of "Sat, 01 Sep 2012 14:17:50 -0400") Mail-Followup-To: Martin Blais , bug-gnu-emacs@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63661 Archived-At: Martin Blais writes: > On Sat, Sep 1, 2012, at 11:29, Christopher Schmidt wrote: >> Those processes that have a nil query-on-exit-flag should be killed >> by compilation-start without a yes-or-no query. A buffer-local >> non-nil value for compilation-always-kill allows me to achieve that. >> >> I still think a check for query-on-exit-flag in compilation-start is >> a good idea. Non-nil query-on-exit-flag and non-nil buffer-local >> compilation-always-kill feels redundant, doesn't it? > > Maybe what we should do is this (just an idea, not sure if it'll make > sense to you): > > 1. Make the compile code check the process-query-on-exit-flag instead > of the compilation-always-kill variable. This would simplify matters, > in that there's a single flag that decides whether to kill the running > process, and it's the same flag that's already being used for when you > kill a buffer. One thing. > > 2. Provide a way to set the default value of > process-query-on-exit-flag on compile subprocesses easier than the > hook/comment. Suppressing the ask on recompile is a very common desire > BTW--some people have packages to do just that--and IMO being able to > customize this via a dedicated variable is valuable. > > What do you think? This is IMO a lot more intuitive than having a variable that unconditionally removes the prompt. I'd go for it. Christopher