From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Antoine Levitt Newsgroups: gmane.emacs.bugs Subject: bug#12895: 24.3.50; Replacement for flet Date: Thu, 15 Nov 2012 23:42:26 +0100 Message-ID: <87wqxm5vzh.fsf@gmail.com> References: <87a9uj9efm.fsf@gmail.com> <87lie27vvd.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1353019407 19759 80.91.229.3 (15 Nov 2012 22:43:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Nov 2012 22:43:27 +0000 (UTC) Cc: 12895@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 15 23:43:37 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TZ89p-0002t1-Cg for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Nov 2012 23:43:37 +0100 Original-Received: from localhost ([::1]:34307 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ89f-0003tK-Ej for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Nov 2012 17:43:27 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ89a-0003sr-9Q for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 17:43:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZ89X-0002lX-7R for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 17:43:22 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ89X-0002lT-3g for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 17:43:19 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TZ8AD-0004U2-RD for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 17:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Antoine Levitt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Nov 2012 22:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12895 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 12895-submit@debbugs.gnu.org id=B12895.135301939617171 (code B ref 12895); Thu, 15 Nov 2012 22:44:01 +0000 Original-Received: (at 12895) by debbugs.gnu.org; 15 Nov 2012 22:43:16 +0000 Original-Received: from localhost ([127.0.0.1]:46143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TZ89T-0004St-GJ for submit@debbugs.gnu.org; Thu, 15 Nov 2012 17:43:16 -0500 Original-Received: from mail-wi0-f174.google.com ([209.85.212.174]:34695) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TZ89R-0004Sl-26 for 12895@debbugs.gnu.org; Thu, 15 Nov 2012 17:43:13 -0500 Original-Received: by mail-wi0-f174.google.com with SMTP id hq12so1495926wib.15 for <12895@debbugs.gnu.org>; Thu, 15 Nov 2012 14:42:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=I1/KiYx2wutaAdsXhLDFN1xBcR9l/aQRz1KQJ6ZfCSs=; b=PMTiZ4PiSYpqVnBoF4o9x/nseXBn2T7IRObjED1WTtuPRrXRfPMNgDQTf3kb9gg+j9 f+EOVW3ZcIL1Ifgl7QAFqSrypnJFd3CCfztI3NjpXKM4WSomUoSK3JFRQBps30p3iUUo qqM5XOFwJbiyzFn2w+MpUbL1u3zT3vsd3/zW+S9u9NhN9XSEmutXtVzqyevBoNTyVLaQ jHJ3VUHpdeJHpQUD66TAxQqN7eCYTogeo71EtcQo6s0Ge47yqZNjLZuwLcSwIC+WPPw5 Rd0EABOpi5id8jpauX/66OVPFw2e3CDyISVY8BxaU3I6ecTMizLZl7KZe4nLemGIa/z6 cHQQ== Original-Received: by 10.216.28.140 with SMTP id g12mr1266676wea.59.1353019349029; Thu, 15 Nov 2012 14:42:29 -0800 (PST) Original-Received: from sigma (ney92-7-78-233-218-202.fbx.proxad.net. [78.233.218.202]) by mx.google.com with ESMTPS id w5sm9591037wiz.10.2012.11.15.14.42.27 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Nov 2012 14:42:28 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Thu, 15 Nov 2012 13:35:34 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-Spam-Score: -0.7 (/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66972 Archived-At: 11/15/2012 19:35, Stefan Monnier >>> Such override should be done with an advice. >> Unless I'm missing something easier, using an advice would be cumbersome >> (define the advice, activate it, run the function, then deactivate the >> advice, protecting for errors). Would you consider un-obsoleting flet? >> It isn't deprecated by either cl-flet or cl-letf. > > Overriding a function is bad. It can mess things up and throw you > majorly off-course when debugging the problem. So are advices. I have lots of flet in my .emacs, usually to suppress messages from functions which are defined elsewhere. For instance, (defun my-org-agenda-to-appt () (interactive) (flet ((message (&rest args) )) (org-agenda-to-appt))) The point is I do not want to redefine org-agenda-to-appt, because I don't want to have to maintain a parallel copy of it. To get away with it without too much effort, I'm just going to have to redefine flet without the obsolete part in my .emacs, which is suboptimal.