From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: Why timers are now catching errors Date: Sun, 13 Jan 2013 16:51:14 +0100 Organization: Emacs Helm Message-ID: <87wqvhgjyl.fsf@gmail.com> References: <877gnhb4hj.fsf@gmail.com> <871udpi151.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1358092332 17095 80.91.229.3 (13 Jan 2013 15:52:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Jan 2013 15:52:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 13 16:52:29 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TuPrB-0007g8-Te for ged-emacs-devel@m.gmane.org; Sun, 13 Jan 2013 16:52:22 +0100 Original-Received: from localhost ([::1]:44485 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuPqv-0005mS-Rw for ged-emacs-devel@m.gmane.org; Sun, 13 Jan 2013 10:52:05 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuPqY-0005jY-Am for emacs-devel@gnu.org; Sun, 13 Jan 2013 10:52:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TuPqG-0002fz-Nm for emacs-devel@gnu.org; Sun, 13 Jan 2013 10:51:42 -0500 Original-Received: from mail-we0-f180.google.com ([74.125.82.180]:36956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuPqG-0002fl-Fe for emacs-devel@gnu.org; Sun, 13 Jan 2013 10:51:24 -0500 Original-Received: by mail-we0-f180.google.com with SMTP id t57so1606450wey.39 for ; Sun, 13 Jan 2013 07:51:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version:content-type; bh=9WUxtX62bW2hRy1Zkup45525FT4MYmd5vwl+Mf/vCdk=; b=yZmYsypy82qCmUgmO75WiJePHjnCkHEdxn6PstKJVDULZf08AdqVyvHZTiRBbVBtnU 0f0ixx4hz59eZhMGeMgHXZtkWcgmngUFe3/wpxzM4kRvcPREodCAKWyz4YCqbFoUwfo3 xx5/7ysmLNt1S26+PIDqpAsEttmR9GoJHWZOMCdF3UQpOrumbmcqI00Y/EuWSET8YqXS 2HG/tTpG+2Z+ziTpQsc52i9wS04poG23q3mCmvIWTVSdgCjXhgBOjLvhZCe8pf26oepL Vh1Kprmgf6iGPAV0p1Q51PJOWiuWY66nTtd9o/gPFPJg67zxz8ceN/+kcKFXhnLdR72p lxFg== X-Received: by 10.194.122.98 with SMTP id lr2mr130568998wjb.55.1358092282521; Sun, 13 Jan 2013 07:51:22 -0800 (PST) Original-Received: from dell-14z (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPS id t17sm9525018wiv.6.2013.01.13.07.51.20 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 13 Jan 2013 07:51:21 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Sun, 13 Jan 2013 10:34:22 -0500") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.92 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.125.82.180 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156308 Archived-At: Stefan Monnier writes: >>>> This change will break many commands using timers. >> You should read "annoy", it break nothing, just send repeatedly an >> annoying message. (See eldoc-eval.el) > > Ah, so the problem is the `message' call? > If so, that's easy to fix: wrap the timer's code inside its own > condition-case to catch the error before timer.el does. Of course I can do that. (Already done locally) >> But maybe you are intoducing (temporarily) such code to improve some >> timer functions running in emacs ? > > It's definitely not temporary, no. Silently dropping such errors makes > tracking down bugs much harder, so it's here to stay. Hmm, I see, what about sending such messages only when `debug-on-error' is enabled ? > > Stefan -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997