From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jambunathan K Newsgroups: gmane.emacs.bugs Subject: bug#13686: hi-yellow vs. hi-lock-1 Date: Thu, 07 Mar 2013 00:26:41 +0530 Message-ID: <87wqtkxspi.fsf@gmail.com> References: <878v6vidh7.fsf@gmail.com> <7BC00EAA1AF8466D8F9C17B3CA4E82B8@us.oracle.com> <87bob65sbw.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1362596272 24241 80.91.229.3 (6 Mar 2013 18:57:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Mar 2013 18:57:52 +0000 (UTC) Cc: 'David Koppelman' , 13686@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 06 19:58:13 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UDJXU-0002BD-Hg for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Mar 2013 19:58:08 +0100 Original-Received: from localhost ([::1]:57335 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDJX9-0005V2-0f for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Mar 2013 13:57:47 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:44415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDJX1-0005UX-St for bug-gnu-emacs@gnu.org; Wed, 06 Mar 2013 13:57:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDJWx-0006ay-P1 for bug-gnu-emacs@gnu.org; Wed, 06 Mar 2013 13:57:39 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDJWx-0006ac-LX for bug-gnu-emacs@gnu.org; Wed, 06 Mar 2013 13:57:35 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UDJXO-00062N-FR for bug-gnu-emacs@gnu.org; Wed, 06 Mar 2013 13:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jambunathan K Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Mar 2013 18:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13686 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13686-submit@debbugs.gnu.org id=B13686.136259625223162 (code B ref 13686); Wed, 06 Mar 2013 18:58:02 +0000 Original-Received: (at 13686) by debbugs.gnu.org; 6 Mar 2013 18:57:32 +0000 Original-Received: from localhost ([127.0.0.1]:34718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UDJWp-00061R-TI for submit@debbugs.gnu.org; Wed, 06 Mar 2013 13:57:31 -0500 Original-Received: from mail-pb0-f47.google.com ([209.85.160.47]:63148) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UDJWk-000619-27 for 13686@debbugs.gnu.org; Wed, 06 Mar 2013 13:57:26 -0500 Original-Received: by mail-pb0-f47.google.com with SMTP id rp2so6420207pbb.20 for <13686@debbugs.gnu.org>; Wed, 06 Mar 2013 10:56:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=hWJj2J5Qa/qPdkCLFw/JY2zTBA3lTN9PsfhGSLTxWqs=; b=ttV83nO7f7qlMwpFfuPUaeFruEhu0YbkBfSveuzzbBOXuJWIWl3mBkfrYGsNnOrN52 Xx7mDa5pl2783E5HTOTXeqCrShlDHc/oPcxtmnwSsxgTWEDQDEC8wYj6VltjUZfgT8hv SjzpESY0A9jcRCETo7i5jmYcEucS+y57/i1K5IApCxkpddFp9kupL+oHaJ0F35SFkkun TnV/2QnyAHXE7j6AVe5vX47JPV0meF0ETAXY7ozfNAuEtjYdQDEc1JaAT06XQxIOp+Fq 7Z9N6JdUAI7szn02TAwk/bE+O6I5N5ipcdHfKuQQEqvhWUfYDQkmbv1m5+JTFd4RH6l+ fSiA== X-Received: by 10.68.47.39 with SMTP id a7mr48761395pbn.155.1362596208844; Wed, 06 Mar 2013 10:56:48 -0800 (PST) Original-Received: from debian-6.05 ([115.241.90.1]) by mx.google.com with ESMTPS id zm1sm32427584pbc.26.2013.03.06.10.56.44 (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Wed, 06 Mar 2013 10:56:47 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Wed, 27 Feb 2013 08:46:50 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72173 Archived-At: Stefan Monnier writes: >>> "hi-lock-1", "hi-lock-2", etc. are the best names. >> My earlier mail asked for making the highlighting face a "core" one. So >> having highlight-1, highlight-2 etc as "core" themable faces will make >> theme designers pay attention to it. > > We could definitely add such core faces. But in order for that to > augment current functionality, we still need a way for the user to > specify the highlighting directly by its attribute. Let's focus on core, themable faces. How many you want in what prefix or file. I propose that these faces be named opaquely as hi-lock-N highlight-N font-lock-user-N font-lock-highlight-N font-lock-extra-face-N ---------------------------------------------------------------- I have also proposed that hi-yellow etc be named as hi-lock-color-yellow etc. My overall plan is to have a formalized version of the following with `hi-lock-face-regexp' turned around in to a defcustom. (defvar hi-lock-face-regexp "\\`hi-lock-color") (setq hi-lock-face-defaults ((lambda (regexp) "List of faces that match REGEXP." (delq nil (mapcar (lambda (f) (let ((s (symbol-name f))) (when (string-match regexp s) f))) (reverse (face-list))))) hi-lock-face-regexp)) This way those who want to be prompted with colors and those who want opaque, themable faces will remain happy. ps: I will provide a patch once there is a general agreement on the approach. ---------------------------------------------------------------- > > > Stefan