From: Jambunathan K <kjambunathan@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 'David Koppelman' <koppel@ece.lsu.edu>, 13686@debbugs.gnu.org
Subject: bug#13686: hi-yellow vs. hi-lock-1
Date: Thu, 07 Mar 2013 00:26:41 +0530 [thread overview]
Message-ID: <87wqtkxspi.fsf@gmail.com> (raw)
In-Reply-To: <jwvk3ptuazf.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 27 Feb 2013 08:46:50 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> "hi-lock-1", "hi-lock-2", etc. are the best names.
>> My earlier mail asked for making the highlighting face a "core" one. So
>> having highlight-1, highlight-2 etc as "core" themable faces will make
>> theme designers pay attention to it.
>
> We could definitely add such core faces. But in order for that to
> augment current functionality, we still need a way for the user to
> specify the highlighting directly by its attribute.
Let's focus on core, themable faces. How many you want in what prefix
or file. I propose that these faces be named opaquely as
hi-lock-N
highlight-N
font-lock-user-N
font-lock-highlight-N
font-lock-extra-face-N
----------------------------------------------------------------
I have also proposed that hi-yellow etc be named as
hi-lock-color-yellow etc.
My overall plan is to have a formalized version of the following with
`hi-lock-face-regexp' turned around in to a defcustom.
(defvar hi-lock-face-regexp "\\`hi-lock-color")
(setq hi-lock-face-defaults
((lambda (regexp)
"List of faces that match REGEXP."
(delq nil
(mapcar (lambda (f)
(let ((s (symbol-name f)))
(when (string-match regexp s) f)))
(reverse (face-list)))))
hi-lock-face-regexp))
This way those who want to be prompted with colors and those who want
opaque, themable faces will remain happy.
ps: I will provide a patch once there is a general agreement on the
approach.
----------------------------------------------------------------
>
>
> Stefan
next prev parent reply other threads:[~2013-03-06 18:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 6:14 bug#13686: 24.3.50; Re-look hi-lock-face-defaults (aka Provide more "core" faces for highlighting) Jambunathan K
2013-02-15 15:03 ` Stefan Monnier
2013-02-15 18:29 ` David Koppelman
2013-02-15 20:39 ` Stefan Monnier
2013-02-26 23:11 ` bug#13686: hi-yellow vs. hi-lock-1 David Koppelman
2013-02-27 0:33 ` Drew Adams
2013-02-27 1:35 ` Stefan Monnier
2013-02-27 3:59 ` Jambunathan K
2013-02-27 4:58 ` Drew Adams
2013-02-27 5:10 ` Jambunathan K
2013-02-27 5:38 ` Drew Adams
2013-02-27 5:54 ` Jambunathan K
2013-02-27 6:01 ` Drew Adams
2013-02-27 23:45 ` Juri Linkov
2013-03-06 18:43 ` Jambunathan K
2013-03-06 19:54 ` David Koppelman
2013-03-07 9:16 ` Juri Linkov
2013-03-06 19:04 ` Jambunathan K
2013-02-27 3:49 ` Jambunathan K
2013-02-27 13:46 ` Stefan Monnier
2013-02-27 14:56 ` Jambunathan K
2013-02-27 16:27 ` Stefan Monnier
2013-03-06 18:56 ` Jambunathan K [this message]
2013-03-06 19:55 ` David Koppelman
2013-03-06 20:06 ` Jambunathan K
2013-03-07 0:54 ` David Koppelman
2013-03-07 3:23 ` Jambunathan K
2013-03-09 1:33 ` Stefan Monnier
2013-03-09 2:47 ` Jambunathan K
2013-03-09 3:26 ` Stefan Monnier
2013-04-08 5:31 ` Jambunathan K
2013-04-10 4:11 ` Jambunathan K
2013-04-10 18:33 ` David Koppelman
2013-04-11 4:24 ` Jambunathan K
2013-02-27 3:36 ` Jambunathan K
2013-02-27 4:08 ` Jambunathan K
2013-11-15 4:45 ` bug#13686: 24.3.50; Re-look hi-lock-face-defaults (aka Provide more "core" faces for highlighting) Jambunathan K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqtkxspi.fsf@gmail.com \
--to=kjambunathan@gmail.com \
--cc=13686@debbugs.gnu.org \
--cc=koppel@ece.lsu.edu \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.