From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Llu=C3=ADs?= Vilanova Newsgroups: gmane.emacs.bugs Subject: bug#14168: vc: [bzr] Properly limit revisions in 'vc-bzr-print-log' Date: Tue, 09 Apr 2013 21:47:35 +0200 Message-ID: <87wqsbqyeg.fsf_-_@fimbulvetr.bsc.es> References: <87a9p7v7hs.fsf@fimbulvetr.bsc.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1365536906 26238 80.91.229.3 (9 Apr 2013 19:48:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Apr 2013 19:48:26 +0000 (UTC) To: 14168@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 09 21:48:30 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UPeWr-0005ZY-Vk for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Apr 2013 21:48:30 +0200 Original-Received: from localhost ([::1]:47051 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPeWr-0007LA-Jg for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Apr 2013 15:48:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPeWn-0007Hs-C5 for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2013 15:48:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPeWl-0005Jg-Pc for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2013 15:48:25 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPeWl-0005JX-LJ for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2013 15:48:23 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UPeaI-00058o-9S for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2013 15:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Llu=C3=ADs?= Vilanova Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Apr 2013 19:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14168 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14168-submit@debbugs.gnu.org id=B14168.136553708019697 (code B ref 14168); Tue, 09 Apr 2013 19:52:02 +0000 Original-Received: (at 14168) by debbugs.gnu.org; 9 Apr 2013 19:51:20 +0000 Original-Received: from localhost ([127.0.0.1]:42352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPeZc-00057d-Ju for submit@debbugs.gnu.org; Tue, 09 Apr 2013 15:51:20 -0400 Original-Received: from roura.ac.upc.es ([147.83.33.10]:41449) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPeZZ-00057S-3L for 14168@debbugs.gnu.org; Tue, 09 Apr 2013 15:51:19 -0400 Original-Received: from gw.ac.upc.edu (gw.ac.upc.es [147.83.30.3]) by roura.ac.upc.es (8.13.8/8.13.8) with ESMTP id r39JlZeq011394 for <14168@debbugs.gnu.org>; Tue, 9 Apr 2013 21:47:35 +0200 Original-Received: from localhost (unknown [84.88.51.85]) by gw.ac.upc.edu (Postfix) with ESMTP id A98FE6B01C6 for <14168@debbugs.gnu.org>; Tue, 9 Apr 2013 21:47:35 +0200 (CEST) In-Reply-To: (GNU bug Tracking System's message of "Tue, 09 Apr 2013 19:28:02 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73279 Archived-At: Bazaar's log command supports the "--forward" argument, which can be set in bazaar's configuration file (beyond emacs' knowledge; e.g. using the alias "log = log --forward"). This explains why the current implementation is breaking the declared generic semantics (by assuming "--forward" is not being used). This can be fixed by changing it into: (if (and start-revision (= limit 1)) (list (format "-c%s" start-revision)) (append (when start-revision (list (format "-r%s.." start-revision))) (when limit (list "-l" (format "%s" limit))))) Note that this will still break if both are given and limit is different from 1 (in which case "-c" cannot be used), but this is explicitly forbidden by the generic semantics. Thanks, Lluis