From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: running each test file independently in test/automated Date: Thu, 19 Sep 2013 23:57:14 +0900 Message-ID: <87wqmc7tbp.fsf@gnu.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1379602682 8883 80.91.229.3 (19 Sep 2013 14:58:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Sep 2013 14:58:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Barry OReilly Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 19 16:58:05 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VMfgD-0004sA-AG for ged-emacs-devel@m.gmane.org; Thu, 19 Sep 2013 16:58:05 +0200 Original-Received: from localhost ([::1]:51626 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMfgD-0007E0-1B for ged-emacs-devel@m.gmane.org; Thu, 19 Sep 2013 10:58:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMfg5-0007Dd-LR for emacs-devel@gnu.org; Thu, 19 Sep 2013 10:58:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMffv-0008Au-WC for emacs-devel@gnu.org; Thu, 19 Sep 2013 10:57:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMffv-0008Aq-Sz for emacs-devel@gnu.org; Thu, 19 Sep 2013 10:57:47 -0400 Original-Received: from fl1-119-240-85-246.iba.mesh.ad.jp ([119.240.85.246]:64498 helo=shatin) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1VMffv-0005k6-8o; Thu, 19 Sep 2013 10:57:47 -0400 Original-Received: from handa by shatin with local (Exim 4.80) (envelope-from ) id 1VMffP-0004Al-43; Thu, 19 Sep 2013 23:57:15 +0900 In-Reply-To: (message from Barry OReilly on Tue, 17 Sep 2013 09:47:29 -0400) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163469 Archived-At: In article , Barry OReilly writes: > So the test code byte compilation rule would not stop Make, but would > be captured in the .log file and reported at the end summary report? Yes. Making each test independent is the most important feature of my patch. A bug in a test code doesnt't stop Make. Even if emacs dumps core, Make doesn't stop. > We should have ert-summary-report kill-emacs with positive error code > if there were such errors. That way the overall 'make check' will > still fail if there were build errors. Ah, yes, you are right. --- Kenichi Handa handa@gnu.org