[PATCH] Inconsistent defaults for uniquify

[PATCH] Inconsistent defaults for uniquify

[Matthias Meulien]

After:
 
   emacs -q

in the Options menu I can see that `Use Directory Names in Buffer 
Names' is checked. Then:

   M-! mkdir a; mkdir b; touch a/test; touch b/test
   C-xC-f a/test
   C-xC-f b/test

Then there are two buffers named `test|a' and `test|b'. Uncheck 
`Use...' in the Options menu and check again `Use...' in the 
Options menu. Now buffers are named `a/test' and `b/test'. The 
buffer name style has changed!!

Line 12227 of `menu-bar.el' and line 96 of uniquify.el define 
different defaults for `uniquify-buffer-name-style'.

diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el
index 13c4c36..38fe5ab 100644
--- a/lisp/menu-bar.el
+++ b/lisp/menu-bar.el
@@ -1226,7 +1226,7 @@ mail status in mode line"))
        (require 'uniquify)
        (setq uniquify-buffer-name-style
 	     (if (not uniquify-buffer-name-style)
-		 'forward))))
+		 'post-forward))))
 
     (bindings--define-key menu [edit-options-separator]
       menu-bar-separator)

-- 
Matthias

Re: Inconsistent defaults for uniquify

[Juri Linkov]

>        (require 'uniquify)
>        (setq uniquify-buffer-name-style
> 	     (if (not uniquify-buffer-name-style)
> -		 'forward))))
> +		 'post-forward))))

Why the default is `post-forward'?  Its formatting "name|bar/mumble"
is too confusing, especially for newbies that might have a hard time
understanding what does this `|' mean that usually indicates the
logical `or' operator.

OTOH, `post-forward-angle-brackets' with "name<bar/mumble>"
is backward-compatible with the naming standard "name<2>"
so it doesn't break customizations in display-buffer-alist
that contains such regexps as "\\*Buffer\\*<[^>]+>".

Re: Inconsistent defaults for uniquify

[Stefan Monnier]

> OTOH, `post-forward-angle-brackets' with "name<bar/mumble>"
> is backward-compatible with the naming standard "name<2>"
> so it doesn't break customizations in display-buffer-alist
> that contains such regexps as "\\*Buffer\\*<[^>]+>".

Go for it.


        Stefan