From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#14153: 24.3.50; regression: `crm--choose-completion-string' expects wrong args Date: Sat, 08 Feb 2014 04:46:28 -0800 Message-ID: <87wqh5rcuz.fsf@building.gnus.org> References: <9A0D74D4FB64407CB482839873E8B61D@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1391863690 12332 80.91.229.3 (8 Feb 2014 12:48:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Feb 2014 12:48:10 +0000 (UTC) Cc: 14153@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 08 13:48:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WC7KS-0007nV-9y for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Feb 2014 13:48:16 +0100 Original-Received: from localhost ([::1]:46363 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WC7KR-0006de-WB for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Feb 2014 07:48:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WC7KK-0006dW-6x for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 07:48:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WC7KE-0006hr-P2 for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 07:48:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WC7KE-0006hl-Ld for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 07:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WC7KD-0000hg-VQ for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 07:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Feb 2014 12:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14153-submit@debbugs.gnu.org id=B14153.13918636782688 (code B ref 14153); Sat, 08 Feb 2014 12:48:01 +0000 Original-Received: (at 14153) by debbugs.gnu.org; 8 Feb 2014 12:47:58 +0000 Original-Received: from localhost ([127.0.0.1]:56630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WC7K9-0000hI-JV for submit@debbugs.gnu.org; Sat, 08 Feb 2014 07:47:57 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:35312) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WC7K7-0000hA-IS for 14153@debbugs.gnu.org; Sat, 08 Feb 2014 07:47:56 -0500 Original-Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WC7Jq-0002de-Dn; Sat, 08 Feb 2014 13:47:38 +0100 In-Reply-To: (Stefan Monnier's message of "Sat, 06 Apr 2013 20:46:10 -0400") User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) X-MailScanner-ID: 1WC7Jq-0002de-Dn MailScanner-NULL-Check: 1392468461.44814@LWKfFeGnu9rX+jGtAIXEnQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:84950 Archived-At: Stefan Monnier writes: >> Each such function should accept 4 args, as follows: > >> CHOICE - the string to insert in the buffer, >> BUFFER - the buffer in which the choice should be inserted, >> MINI-P - non-nil if BUFFER is a minibuffer, and >> BASE-SIZE - the number of characters in BUFFER before >> the string being completed. > > Duh, sorry indeed, could you please update this docstring to match the code? > >> But `crm--choose-completion-string' expects these args: >> (CHOICE BUFFER BASE-POSITION &rest IGNORED) > > Which is indeed the correct calling convention nowadays. Fixed on trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/