all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 14153@debbugs.gnu.org
Subject: bug#14153: 24.3.50; regression: `crm--choose-completion-string' expects wrong args
Date: Sat, 08 Feb 2014 04:46:28 -0800	[thread overview]
Message-ID: <87wqh5rcuz.fsf@building.gnus.org> (raw)
In-Reply-To: <jwv8v4v2mpc.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 06 Apr 2013 20:46:10 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Each such function should accept 4 args, as follows:
>
>>  CHOICE - the string to insert in the buffer,
>>  BUFFER - the buffer in which the choice should be inserted,
>>  MINI-P - non-nil if BUFFER is a minibuffer, and
>>  BASE-SIZE - the number of characters in BUFFER before
>>           the string being completed.
>
> Duh, sorry indeed, could you please update this docstring to match the code?
>
>> But `crm--choose-completion-string' expects these args:
>>  (CHOICE  BUFFER  BASE-POSITION  &rest IGNORED)
>
> Which is indeed the correct calling convention nowadays.

Fixed on trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





      parent reply	other threads:[~2014-02-08 12:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-06 21:25 bug#14153: 24.3.50; regression: `crm--choose-completion-string' expects wrong args Drew Adams
2013-04-07  0:46 ` Stefan Monnier
2013-04-07  2:00   ` Drew Adams
2013-04-07  2:09     ` Drew Adams
2014-02-08 12:46   ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqh5rcuz.fsf@building.gnus.org \
    --to=larsi@gnus.org \
    --cc=14153@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.