From: Johan Claesson <johanclaesson@bredband.net>
To: Leo Liu <sdl.web@gmail.com>
Cc: Xue Fuqiao <xfq@gnu.org>, 12357@debbugs.gnu.org
Subject: bug#12357: 24.2; list-load-path-shadow should ignore .dir-locals.el
Date: Wed, 05 Mar 2014 08:25:03 +0100 [thread overview]
Message-ID: <87wqg9p0og.fsf@bredband.net> (raw)
In-Reply-To: <m1eh2hfoso.fsf@gmail.com> (Leo Liu's message of "Wed, 05 Mar 2014 08:54:15 +0800")
Well i would like the false positives to go away. That is the problem
this attempts to fix.
How about a defvar load-path-shadows-report-dir-locals instead?
It would of course be true by default to preserve legacy behaviour.
I agree that list-dir-locals-shadows is not very useful. It was written
only to motivate that list-load-path-shadows should not report
.dir-locals.el.
Regards,
/Johan
Leo Liu <sdl.web@gmail.com> writes:
> On 2014-03-05 06:29 +0800, Johan Claesson wrote:
>> * emacs-lisp/shadows.el (load-path-shadows-find): Do not report
>> .dir-locals.el files.
>> (list-dir-locals-shadows): New command that reports shadows of
>> .dir-locals.el in a way that make sense for that type of file.
>> (dir-locals-shadows-find, dir-locals-shadows-find-1)
>> (dir-locals-class-name, dir-locals-shadows-display): Auxiliary
>> functions for list-dir-locals-shadows.
>
> I am not too sure what problems are solved by the change.
>
> In the case of list-load-path-shadows, it should print anything when in
> doubt since false positives can be helpful. So it is not entirely wrong
> to report .dir-locals.el.
>
> Use .dir-locals.el in a child directory to shadow parent directory isn't
> uncommon practice. In future we might even make it capable of inheriting
> settings in parent directory. So I am not even sure the use case of
> listing .dir-locals files (defaulting to the load-path)??
>
> Leo
prev parent reply other threads:[~2014-03-05 7:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 13:38 bug#12357: 24.2; list-load-path-shadow should ignore .dir-locals.el Johan Claesson
2012-09-05 16:23 ` Johan Claesson
2012-09-08 1:13 ` Glenn Morris
2012-09-08 14:08 ` Johan Claesson
2012-09-16 18:56 ` Johan Claesson
2014-02-26 8:49 ` Xue Fuqiao
2014-03-02 22:14 ` Johan Claesson
2014-03-02 22:36 ` Xue Fuqiao
2014-03-04 22:29 ` Johan Claesson
2014-03-05 0:54 ` Leo Liu
2014-03-05 7:09 ` Johan Claesson
2014-03-06 2:07 ` Glenn Morris
2014-03-06 21:58 ` Johan Claesson
2014-03-05 7:25 ` Johan Claesson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqg9p0og.fsf@bredband.net \
--to=johanclaesson@bredband.net \
--cc=12357@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
--cc=xfq@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.