VC to bind coding-system while invoking Git

VC to bind coding-system while invoking Git

[Eli Zaretskii]

vc-git-command should bind coding-system-for-read/write to the value
of vc-git-commits-coding-system (utf-8 by default).  Currently, we
only do that for a handful of Git commands, which is inconsistent.
The result is, for example, that typing RET in a *vc-change-log*
buffer might show the non-ASCII characters incorrectly if the default
for process-coding-system is not UTF-8.

Likewise with vc-git--call.

Any objections?

Re: VC to bind coding-system while invoking Git

[Andreas Schwab]

Eli Zaretskii <eliz@gnu.org> writes:

> vc-git-command should bind coding-system-for-read/write to the value
> of vc-git-commits-coding-system (utf-8 by default).  Currently, we
> only do that for a handful of Git commands, which is inconsistent.
> The result is, for example, that typing RET in a *vc-change-log*
> buffer might show the non-ASCII characters incorrectly if the default
> for process-coding-system is not UTF-8.

It should also take i18n.commitEncoding and i18n.logOutputEncoding into
account.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: VC to bind coding-system while invoking Git

[Eli Zaretskii]

> From: Andreas Schwab <schwab@linux-m68k.org>
> Cc: emacs-devel@gnu.org
> Date: Mon, 17 Nov 2014 18:47:24 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > vc-git-command should bind coding-system-for-read/write to the value
> > of vc-git-commits-coding-system (utf-8 by default).  Currently, we
> > only do that for a handful of Git commands, which is inconsistent.
> > The result is, for example, that typing RET in a *vc-change-log*
> > buffer might show the non-ASCII characters incorrectly if the default
> > for process-coding-system is not UTF-8.
> 
> It should also take i18n.commitEncoding and i18n.logOutputEncoding into
> account.

Any better way than to run "git config" querying about these 2 before
every git command?

Re: VC to bind coding-system while invoking Git

[Eli Zaretskii]

> Date: Mon, 17 Nov 2014 21:01:59 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> > From: Andreas Schwab <schwab@linux-m68k.org>
> > Cc: emacs-devel@gnu.org
> > Date: Mon, 17 Nov 2014 18:47:24 +0100
> > 
> > Eli Zaretskii <eliz@gnu.org> writes:
> > 
> > > vc-git-command should bind coding-system-for-read/write to the value
> > > of vc-git-commits-coding-system (utf-8 by default).  Currently, we
> > > only do that for a handful of Git commands, which is inconsistent.
> > > The result is, for example, that typing RET in a *vc-change-log*
> > > buffer might show the non-ASCII characters incorrectly if the default
> > > for process-coding-system is not UTF-8.
> > 
> > It should also take i18n.commitEncoding and i18n.logOutputEncoding into
> > account.
> 
> Any better way than to run "git config" querying about these 2 before
> every git command?

I pushed a simple change to emacs-24 that just binds the encoding to
vc-git-commits-coding-system.  I will work on a more complex solution
for the trunk.