From: Thien-Thi Nguyen <ttn@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] version.el (emacs-repository-get-version): Let git change the directory.
Date: Tue, 18 Nov 2014 11:17:24 +0100 [thread overview]
Message-ID: <87wq6slsnf.fsf@zigzag.favinet> (raw)
In-Reply-To: <1416271305-6656-1-git-send-email-mina86@mina86.com> (Michal Nazarewicz's message of "Tue, 18 Nov 2014 01:41:45 +0100")
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
() Michal Nazarewicz <mina86@mina86.com>
() Tue, 18 Nov 2014 01:41:45 +0100
- (and (eq 0
+ (and (zerop (condition-case nil
Two problems: (a) This change introduces the possibility of
evaling ‘(zerop nil)’, which throws ‘wrong-type-argument’;
(b) the ChangeLog entry does not mention the change.
--
Thien-Thi Nguyen
GPG key: 4C807502
(if you're human and you know it)
read my lisp: (responsep (questions 'technical)
(not (via 'mailing-list)))
=> nil
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2014-11-18 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 0:41 [PATCH] version.el (emacs-repository-get-version): Let git change the directory Michal Nazarewicz
2014-11-18 1:52 ` Glenn Morris
2014-11-18 10:17 ` Thien-Thi Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wq6slsnf.fsf@zigzag.favinet \
--to=ttn@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.