From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: dieter@duenenhof-wilhelm.de (H. Dieter Wilhelm) Newsgroups: gmane.emacs.bugs Subject: bug#19129: 25.0.50; recenter-positions is missing a reference to move-to-window-line-top-bottom Date: Fri, 21 Nov 2014 09:52:13 +0100 Message-ID: <87wq6p9br6.fsf@vsl28t2g.ww011> References: <87r3wxbju9.fsf@vsl28t2g.ww011> <831tox5692.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416560008 19651 80.91.229.3 (21 Nov 2014 08:53:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Nov 2014 08:53:28 +0000 (UTC) Cc: 19129@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 21 09:53:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xrjxs-0006k7-Je for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Nov 2014 09:53:16 +0100 Original-Received: from localhost ([::1]:39240 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrjxs-0004gX-AL for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Nov 2014 03:53:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrjxj-0004ct-Sf for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 03:53:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xrjxe-00086B-Lw for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 03:53:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xrjxe-000867-ID for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 03:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Xrjxe-0002Gj-AU for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 03:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: dieter@duenenhof-wilhelm.de (H. Dieter Wilhelm) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Nov 2014 08:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19129 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19129-submit@debbugs.gnu.org id=B19129.14165599388664 (code B ref 19129); Fri, 21 Nov 2014 08:53:02 +0000 Original-Received: (at 19129) by debbugs.gnu.org; 21 Nov 2014 08:52:18 +0000 Original-Received: from localhost ([127.0.0.1]:40220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xrjww-0002Fg-15 for submit@debbugs.gnu.org; Fri, 21 Nov 2014 03:52:18 -0500 Original-Received: from mail-wi0-f178.google.com ([209.85.212.178]:39474) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xrjwt-0002FX-Lj for 19129@debbugs.gnu.org; Fri, 21 Nov 2014 03:52:16 -0500 Original-Received: by mail-wi0-f178.google.com with SMTP id hi2so8016392wib.5 for <19129@debbugs.gnu.org>; Fri, 21 Nov 2014 00:52:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=rpgXeFBDyTPQTWMrfOEsektsK0RkD7jeLB9w455p0JY=; b=oJINcp/wmZfCY7Y80A9i1Se65xX4y0d5MqMRko2hIhmGvJnZyk6aAux7pK08YimCrG +Y8hlqA4Dujo7rgUuPOtlW+znkt0VrdhzT+a8mXEMm5ancnIOml9EooSBDHgXi2O2vN3 6RXV8SNgbrgX+pBR5lRn1FZXwGZABgq1FOIceY5wJFQFxlA918pe/gfk5PI35vKEPj57 6NrTsHAjxbsoTTwpqseQq3RaM297xtB1W62aCzyRspJcbrCw0Krn4Nb9uJZFWx32QgaH WI/iCo6vphYlP3WIsDd9fv+BtWXAQYvTp/RB0qsZY/y/M7n4M2uCW71UqV04X2AilS/S jv8A== X-Received: by 10.194.85.83 with SMTP id f19mr5511668wjz.20.1416559935044; Fri, 21 Nov 2014 00:52:15 -0800 (PST) Original-Received: from vsl28t2g.ww011 (p57ACDBB7.dip0.t-ipconnect.de. [87.172.219.183]) by mx.google.com with ESMTPSA id wx3sm7127767wjc.19.2014.11.21.00.52.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Nov 2014 00:52:14 -0800 (PST) In-Reply-To: <831tox5692.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Nov 2014 10:04:41 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96358 Eli Zaretskii writes: >> From: dieter@duenenhof-wilhelm.de (H. Dieter Wilhelm) >> Date: Thu, 20 Nov 2014 23:14:38 +0100 >> >> in the documentation for recenter-positions was forgotten that it is >> also used in move-to-window-line-top-bottom. I added below patch as an >> illustration. > > Nitpicking: In the future, please try to avoid unnecessarily changing > parts that are unrelated to the proposed patch. This is especially > true for human-readable text (as opposed to code), because it makes it > very hard to determine where are you actually changing something. I understand, I'll try to avoid it. > In the case in point, I'm guessing you've filled the paragraphs of the > doc string, which wasn't really necessary, since the lines were of > reasonable length. Yes, that's right, but I did it mistakenly because I thought it was forgotten and that filling a paragraph would be necessary to be in accordance to Elisp coding conventions. Now I learned that even though emacs-lisp-docstring-fill-column is 65 an 80 column filling might be acceptable! Thanks for the pointer. Dieter -- Best wishes H. Dieter Wilhelm Darmstadt, Germany