* bug#20245: 24.5; c++-mode font-lock broken by the last commit to emacs24 branch @ 2015-04-02 6:55 Oleh Krehel [not found] ` <mailman.3171.1427958137.31049.bug-gnu-emacs@gnu.org> [not found] ` <mailman.3178.1427970015.31049.bug-gnu-emacs@gnu.org> 0 siblings, 2 replies; 9+ messages in thread From: Oleh Krehel @ 2015-04-02 6:55 UTC (permalink / raw) To: 20245; +Cc: acm Hello, The font-locking of at least C++ headers was broken in "d69e9f1". Here's a screenshot: http://i.imgur.com/eT6X3hP.png. You can see three artifacts there. They change number and location when I scroll. It goes back to a good state if I revert the commit and re-compile. I hope this gets fixed by 24.5 release, even by just reverting "d69e9f1", since this one is a bigger bug than http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19669, which "d69e9f1" fixes. Oleh ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <mailman.3171.1427958137.31049.bug-gnu-emacs@gnu.org>]
* bug#20245: 24.5; c++-mode font-lock broken by the last commit to emacs24 branch [not found] ` <mailman.3171.1427958137.31049.bug-gnu-emacs@gnu.org> @ 2015-04-02 9:51 ` Alan Mackenzie 2015-04-02 10:19 ` Oleh Krehel 0 siblings, 1 reply; 9+ messages in thread From: Alan Mackenzie @ 2015-04-02 9:51 UTC (permalink / raw) To: 20245; +Cc: Oleh Krehel Hello, Oleh. In article <mailman.3171.1427958137.31049.bug-gnu-emacs@gnu.org> you wrote: > The font-locking of at least C++ headers was broken in "d69e9f1". > Here's a screenshot: http://i.imgur.com/eT6X3hP.png. You can see three > artifacts there. They change number and location when I scroll. This was fixed very recently in the master branch. Would you please try the same file in master to confirm that the fix is a fix. > It goes back to a good state if I revert the commit and re-compile. > I hope this gets fixed by 24.5 release, even by just reverting > "d69e9f1", since this one is a bigger bug than > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19669, which "d69e9f1" fixes. > Oleh -- Alan Mackenzie (Nuremberg, Germany). ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#20245: 24.5; c++-mode font-lock broken by the last commit to emacs24 branch 2015-04-02 9:51 ` Alan Mackenzie @ 2015-04-02 10:19 ` Oleh Krehel 2015-04-03 12:46 ` Alan Mackenzie 0 siblings, 1 reply; 9+ messages in thread From: Oleh Krehel @ 2015-04-02 10:19 UTC (permalink / raw) To: Alan Mackenzie; +Cc: 20245 Hi, Alan. On Thu, Apr 2, 2015 at 11:51 AM, Alan Mackenzie <acm@muc.de> wrote: > Hello, Oleh. > > In article <mailman.3171.1427958137.31049.bug-gnu-emacs@gnu.org> you wrote: > >> The font-locking of at least C++ headers was broken in "d69e9f1". >> Here's a screenshot: http://i.imgur.com/eT6X3hP.png. You can see three >> artifacts there. They change number and location when I scroll. > > This was fixed very recently in the master branch. Would you please try > the same file in master to confirm that the fix is a fix. I just tried "23bb07e", the latest commit on master, but this issue isn't fixed. The include statements look the same as in the screenshot. Oleh ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#20245: 24.5; c++-mode font-lock broken by the last commit to emacs24 branch 2015-04-02 10:19 ` Oleh Krehel @ 2015-04-03 12:46 ` Alan Mackenzie 2015-04-06 22:40 ` Alan Mackenzie 0 siblings, 1 reply; 9+ messages in thread From: Alan Mackenzie @ 2015-04-03 12:46 UTC (permalink / raw) To: Oleh Krehel; +Cc: 20245-done Hello, Oleh. On Thu, Apr 02, 2015 at 12:19:36PM +0200, Oleh Krehel wrote: > On Thu, Apr 2, 2015 at 11:51 AM, Alan Mackenzie <acm@muc.de> wrote: > > In article <mailman.3171.1427958137.31049.bug-gnu-emacs@gnu.org> you wrote: > >> The font-locking of at least C++ headers was broken in "d69e9f1". > >> Here's a screenshot: http://i.imgur.com/eT6X3hP.png. You can see three > >> artifacts there. They change number and location when I scroll. > > This was fixed very recently in the master branch. Would you please try > > the same file in master to confirm that the fix is a fix. > I just tried "23bb07e", the latest commit on master, but this issue isn't fixed. > The include statements look the same as in the screenshot. I've looked at this problem and now understand its cause. It's too involved to fix for Emacs 24.5, so we've decided to revert that commit, as you've suggested. A proper fix will surely be included in Emacs 25.1 (or 24.6, whichever comes first). Thanks for taking the trouble to report this bug. I'm closing it now. > Oleh -- Alan Mackenzie (Nuremberg, Germany). ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#20245: 24.5; c++-mode font-lock broken by the last commit to emacs24 branch 2015-04-03 12:46 ` Alan Mackenzie @ 2015-04-06 22:40 ` Alan Mackenzie 2015-04-07 12:17 ` Oleh Krehel 0 siblings, 1 reply; 9+ messages in thread From: Alan Mackenzie @ 2015-04-06 22:40 UTC (permalink / raw) To: 20245, ohwoeowho Hello, Oleh. On Fri, Apr 03, 2015 at 12:46:53PM +0000, Alan Mackenzie wrote: > On Thu, Apr 02, 2015 at 12:19:36PM +0200, Oleh Krehel wrote: > > On Thu, Apr 2, 2015 at 11:51 AM, Alan Mackenzie <acm@muc.de> wrote: > > > In article <mailman.3171.1427958137.31049.bug-gnu-emacs@gnu.org> you wrote: > > I just tried "23bb07e", the latest commit on master, but this issue isn't fixed. > > The include statements look the same as in the screenshot. > I've looked at this problem and now understand its cause. It's too > involved to fix for Emacs 24.5, so we've decided to revert that commit, > as you've suggested. A proper fix will surely be included in Emacs 25.1 > (or 24.6, whichever comes first). I've now committed a (hopefully) proper fix for this into the master branch at savannah. Feel free to download this and check that it does indeed work properly. If not ... > > Oleh -- Alan Mackenzie (Nuremberg, Germany). ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#20245: 24.5; c++-mode font-lock broken by the last commit to emacs24 branch 2015-04-06 22:40 ` Alan Mackenzie @ 2015-04-07 12:17 ` Oleh Krehel 0 siblings, 0 replies; 9+ messages in thread From: Oleh Krehel @ 2015-04-07 12:17 UTC (permalink / raw) To: Alan Mackenzie; +Cc: 20245 Alan Mackenzie <acm@muc.de> writes: Hi Alan, > On Fri, Apr 03, 2015 at 12:46:53PM +0000, Alan Mackenzie wrote: > > I've now committed a (hopefully) proper fix for this into the master > branch at savannah. Feel free to download this and check that it does > indeed work properly. If not ... It works great. Thanks a lot. regards, Oleh ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <mailman.3178.1427970015.31049.bug-gnu-emacs@gnu.org>]
* bug#20245: 24.5; c++-mode font-lock broken by the last commit to emacs24 branch [not found] ` <mailman.3178.1427970015.31049.bug-gnu-emacs@gnu.org> @ 2015-04-02 12:48 ` Alan Mackenzie 2015-04-02 13:10 ` Oleh Krehel 0 siblings, 1 reply; 9+ messages in thread From: Alan Mackenzie @ 2015-04-02 12:48 UTC (permalink / raw) To: Oleh Krehel; +Cc: 20245 Hello, Oleh. In article <mailman.3178.1427970015.31049.bug-gnu-emacs@gnu.org> you wrote: > Hi, Alan. > On Thu, Apr 2, 2015 at 11:51 AM, Alan Mackenzie <acm@muc.de> wrote: >> In article <mailman.3171.1427958137.31049.bug-gnu-emacs@gnu.org> you wrote: >>> The font-locking of at least C++ headers was broken in "d69e9f1". >>> Here's a screenshot: http://i.imgur.com/eT6X3hP.png. You can see three >>> artifacts there. They change number and location when I scroll. >> This was fixed very recently in the master branch. Would you please try >> the same file in master to confirm that the fix is a fix. > I just tried "23bb07e", the latest commit on master, but this issue isn't fixed. > The include statements look the same as in the screenshot. That's a pity. It looks like there's a separate problem with the "fix" from February. Is there any chance you could send me a copy of the file which triggers the bug, a description of exactly what you do to see it, and (unless you start from emacs -Q) a copy of your CC Mode configuration (generated by C-c C-b)? Thanks! > Oleh -- Alan Mackenzie (Nuremberg, Germany). ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#20245: 24.5; c++-mode font-lock broken by the last commit to emacs24 branch 2015-04-02 12:48 ` Alan Mackenzie @ 2015-04-02 13:10 ` Oleh Krehel 2015-04-02 13:32 ` Alan Mackenzie 0 siblings, 1 reply; 9+ messages in thread From: Oleh Krehel @ 2015-04-02 13:10 UTC (permalink / raw) To: Alan Mackenzie; +Cc: 20245 Hi Alan, On Thu, Apr 2, 2015 at 2:48 PM, Alan Mackenzie <acm@muc.de> wrote: >> I just tried "23bb07e", the latest commit on master, but this issue isn't fixed. >> The include statements look the same as in the screenshot. > > That's a pity. It looks like there's a separate problem with the "fix" > from February. > > Is there any chance you could send me a copy of the file which triggers > the bug, a description of exactly what you do to see it, and (unless you > start from emacs -Q) a copy of your CC Mode configuration (generated by > C-c C-b)? The bug is reproducible with emacs -Q. You can get an example file at: https://github.com/dune-project/dune-pdelab-howto/blob/master/src/navier-stokes/cgstokes_instat.cc To trigger the bug, just M->, and then scroll up with the mouse to the start of the file where the headers are. Random headers will be partially highlighted with 'default instead of 'font-lock-string-face. Oleh ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#20245: 24.5; c++-mode font-lock broken by the last commit to emacs24 branch 2015-04-02 13:10 ` Oleh Krehel @ 2015-04-02 13:32 ` Alan Mackenzie 0 siblings, 0 replies; 9+ messages in thread From: Alan Mackenzie @ 2015-04-02 13:32 UTC (permalink / raw) To: Oleh Krehel; +Cc: 20245 Hello, Oleh. On Thu, Apr 02, 2015 at 03:10:57PM +0200, Oleh Krehel wrote: > The bug is reproducible with emacs -Q. You can get an example file at: > https://github.com/dune-project/dune-pdelab-howto/blob/master/src/navier-stokes/cgstokes_instat.cc > To trigger the bug, just M->, and then scroll up with the mouse to the > start of the file where the headers are. Random headers will be > partially highlighted with 'default instead of 'font-lock-string-face. Thanks. I've got that file, and I do indeed see the bug in it. > Oleh -- Alan Mackenzie (Nuremberg, Germany). ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-04-07 12:17 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-04-02 6:55 bug#20245: 24.5; c++-mode font-lock broken by the last commit to emacs24 branch Oleh Krehel [not found] ` <mailman.3171.1427958137.31049.bug-gnu-emacs@gnu.org> 2015-04-02 9:51 ` Alan Mackenzie 2015-04-02 10:19 ` Oleh Krehel 2015-04-03 12:46 ` Alan Mackenzie 2015-04-06 22:40 ` Alan Mackenzie 2015-04-07 12:17 ` Oleh Krehel [not found] ` <mailman.3178.1427970015.31049.bug-gnu-emacs@gnu.org> 2015-04-02 12:48 ` Alan Mackenzie 2015-04-02 13:10 ` Oleh Krehel 2015-04-02 13:32 ` Alan Mackenzie
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.