all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Oleh Krehel <ohwoeowho@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: eggert@cs.ucla.edu, monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
Subject: Re: Is it time to remove INTERNAL_FIELD?
Date: Tue, 28 Apr 2015 17:11:58 +0200	[thread overview]
Message-ID: <87wq0wmgn5.fsf@gmail.com> (raw)
In-Reply-To: <83vbgguw9j.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 28 Apr 2015 18:07:20 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Oleh Krehel <ohwoeowho@gmail.com>
>> Cc: Stefan Monnier <monnier@IRO.UMontreal.CA>,  eggert@cs.ucla.edu,  emacs-devel@gnu.org
>> Date: Tue, 28 Apr 2015 09:39:10 +0200
>> 
>> > Unless the concurrency branch is officially and finally dead, I'd like
>> > to keep the underscores, to make it easier to revive that branch, if
>> > and when some volunteer emerges.
>> 
>> I think that a good start towards concurrency is making the code as
>> simple as possible. Removing INTERNAL_FIELD is a tiny step towards that
>> goal.
>
> I'm not against removing INTERNAL_FIELD.  I was only talking about
> keeping the code that appends the underscores to fields in buffer and
> keyboard structures where we were doing that with INTERNAL_FIELD.
>
>> Perhaps, removing some other abstraction mechanisms that don't actually
>> do anything yet (but potentially could be useful in the future) would
>> also be good. Concurrency would come with its own abstractions, I think
>> the old ones would just get in the way.
>
> We append the underscores not as some abstraction, but as an aid to
> catch early code that will interfere with merging the concurrency
> branch.
>
>> Should I update the patch to include the underscores everywhere?
>
> Not everywhere, only where the fields are used in BVAR and KVAR.

So that means everywhere, except allow to use BVAR and KVAR macros
without an underscore. Did I understand correctly?

Oleh



  reply	other threads:[~2015-04-28 15:11 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23  9:55 Is it time to remove INTERNAL_FIELD? Oleh Krehel
2015-04-23 10:08 ` Paul Eggert
2015-04-23 10:10   ` Oleh Krehel
2015-04-23 10:17     ` Paul Eggert
2015-04-23 10:56       ` Eli Zaretskii
2015-04-23 10:56         ` Oleh Krehel
2015-04-23 11:17           ` Eli Zaretskii
2015-04-23 11:32             ` Oleh Krehel
2015-04-23 12:01               ` Eli Zaretskii
2015-04-23 12:05                 ` Oleh Krehel
2015-04-23 12:37                   ` Eli Zaretskii
2015-04-25 10:57                     ` Oleh Krehel
2015-04-25 11:28                       ` Eli Zaretskii
2015-04-25 14:28                         ` Stefan Monnier
2015-04-25 14:41                           ` Eli Zaretskii
2015-04-28  7:39                             ` Oleh Krehel
2015-04-28 13:20                               ` Stefan Monnier
2015-04-28 15:07                               ` Eli Zaretskii
2015-04-28 15:11                                 ` Oleh Krehel [this message]
2015-04-28 15:23                                   ` Eli Zaretskii
2015-04-28 18:58                                     ` Oleh Krehel
2015-04-28 19:21                                       ` Eli Zaretskii
2015-04-23 11:00       ` Eli Zaretskii
2015-04-23 13:24 ` Stefan Monnier
2015-04-23 13:30   ` Oleh Krehel
2015-04-23 13:53     ` Eli Zaretskii
2015-04-23 14:07       ` Oleh Krehel
2015-04-23 14:50         ` Nicolas Richard
2015-04-23 15:34           ` Eli Zaretskii
2015-04-24 10:44             ` Nicolas Richard
2015-04-23 15:29         ` Eli Zaretskii
2015-04-23 16:32           ` Oleh Krehel
2015-04-23 17:00             ` Eli Zaretskii
2015-04-23 17:09               ` Oleh Krehel
2015-04-23 17:29                 ` Eli Zaretskii
2015-04-23 17:14             ` Stefan Monnier
2015-04-23 17:31               ` Eli Zaretskii
2015-04-23 13:30 ` Stefan Monnier
2015-04-23 13:33   ` Oleh Krehel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wq0wmgn5.fsf@gmail.com \
    --to=ohwoeowho@gmail.com \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.