From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#21313: 25.0.50; Strange errors from dbus-handle-event Date: Tue, 22 Sep 2015 07:49:09 +0200 Message-ID: <87wpvjovfu.fsf@gnu.org> References: <877foo4nkd.fsf@gnu.org> <87wpvzs4r3.fsf@gnu.org> <87bnd9cf7g.fsf@gnu.org> <831te53zbq.fsf@gnu.org> <871te5cdg7.fsf@gnu.org> <83wpvx2h16.fsf@gnu.org> <87r3lziti9.fsf@gnu.org> <83zj0n7jtl.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1442901028 19526 80.91.229.3 (22 Sep 2015 05:50:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Sep 2015 05:50:28 +0000 (UTC) Cc: 21313-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 22 07:50:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZeGSx-0007Re-SY for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Sep 2015 07:50:12 +0200 Original-Received: from localhost ([::1]:36752 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeGSx-0007fZ-7G for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Sep 2015 01:50:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeGSt-0007dQ-0Y for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2015 01:50:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeGSp-00019v-Rb for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2015 01:50:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeGSp-00019W-Np for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2015 01:50:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZeGSp-0001Xe-4H for bug-gnu-emacs@gnu.org; Tue, 22 Sep 2015 01:50:03 -0400 Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Sep 2015 05:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 21313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 21313@debbugs.gnu.org, tsdh@gnu.org, tsdh@gnu.org Original-Received: via spool by 21313-done@debbugs.gnu.org id=D21313.14429009555781 (code D ref 21313); Tue, 22 Sep 2015 05:50:02 +0000 Original-Received: (at 21313-done) by debbugs.gnu.org; 22 Sep 2015 05:49:15 +0000 Original-Received: from localhost ([127.0.0.1]:41119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZeGS2-0001VA-OA for submit@debbugs.gnu.org; Tue, 22 Sep 2015 01:49:15 -0400 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:44240) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZeGS0-0001Us-4X for 21313-done@debbugs.gnu.org; Tue, 22 Sep 2015 01:49:13 -0400 Original-Received: from thinkpad-t440p (dhcp207.uni-koblenz.de [141.26.71.207]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 4B5981A8393; Tue, 22 Sep 2015 07:49:10 +0200 (CEST) In-Reply-To: <83zj0n7jtl.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Sep 2015 19:01:42 +0300") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106796 Archived-At: Eli Zaretskii writes: >> I wondered why channel is not removed from Available here. I mean, >> input was available, and then the handlers registered using >> add_read_fd by inotify or dbus consumed the input, so there's >> probably no input left. So I tried this patch >> >> --8<---------------cut here---------------start------------->8--- >> diff --git a/src/process.c b/src/process.c >> index ed5f4c0..7985e37 100644 >> --- a/src/process.c >> +++ b/src/process.c >> @@ -5036,7 +5036,10 @@ wait_reading_process_output (intmax_t time_limit, int nsecs, int read_kbd, >> && FD_ISSET (channel, &Available)) >> || (d->condition & FOR_WRITE >> && FD_ISSET (channel, &write_mask)))) >> - d->func (channel, d->data); >> + { >> + d->func (channel, d->data); >> + FD_CLR (channel, &Available); >> + } >> } >> >> for (channel = 0; channel <= max_process_desc; channel++) >> --8<---------------cut here---------------end--------------->8--- >> >> and since then the problem has not appeared again and I can't see any >> obvious other malfunction. But of course that's really a naive >> change. I can grasp the big picture of wait_reading_process_output >> but not all the details. > > If no one objects in a week, please push this, and let's see what it > breaks. I've run with this patch for about a week now and the issue hasn't occurred anymore. So I just pushed it and close the bug report with this mail. Thanks for your assistance! Bye, Tassilo